Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 2103773002: Occlusion query feature is already in GL ES3.0 spec, not an extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address ken's commments, and add a unit test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/feature_info.h" 5 #include "gpu/command_buffer/service/feature_info.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 1204 matching lines...) Expand 10 before | Expand all | Expand 10 after
1215 SetupInitExpectations("GL_ARB_occlusion_query2 GL_ARB_occlusion_query2"); 1215 SetupInitExpectations("GL_ARB_occlusion_query2 GL_ARB_occlusion_query2");
1216 EXPECT_THAT(info_->extensions(), 1216 EXPECT_THAT(info_->extensions(),
1217 HasSubstr("GL_EXT_occlusion_query_boolean")); 1217 HasSubstr("GL_EXT_occlusion_query_boolean"));
1218 EXPECT_TRUE(info_->feature_flags().occlusion_query_boolean); 1218 EXPECT_TRUE(info_->feature_flags().occlusion_query_boolean);
1219 EXPECT_TRUE(info_->feature_flags( 1219 EXPECT_TRUE(info_->feature_flags(
1220 ).use_arb_occlusion_query2_for_occlusion_query_boolean); 1220 ).use_arb_occlusion_query2_for_occlusion_query_boolean);
1221 EXPECT_FALSE(info_->feature_flags( 1221 EXPECT_FALSE(info_->feature_flags(
1222 ).use_arb_occlusion_query_for_occlusion_query_boolean); 1222 ).use_arb_occlusion_query_for_occlusion_query_boolean);
1223 } 1223 }
1224 1224
1225 TEST_P(FeatureInfoTest, InitializeGLES3_occlusion_query_boolean) {
1226 SetupInitExpectationsWithGLVersion("", "", "OpenGL ES 3.0");
1227 EXPECT_TRUE(info_->feature_flags().occlusion_query_boolean);
1228 }
1229
1225 TEST_P(FeatureInfoTest, InitializeOES_vertex_array_object) { 1230 TEST_P(FeatureInfoTest, InitializeOES_vertex_array_object) {
1226 SetupInitExpectations("GL_OES_vertex_array_object"); 1231 SetupInitExpectations("GL_OES_vertex_array_object");
1227 EXPECT_THAT(info_->extensions(), 1232 EXPECT_THAT(info_->extensions(),
1228 HasSubstr("GL_OES_vertex_array_object")); 1233 HasSubstr("GL_OES_vertex_array_object"));
1229 EXPECT_TRUE(info_->feature_flags().native_vertex_array_object); 1234 EXPECT_TRUE(info_->feature_flags().native_vertex_array_object);
1230 } 1235 }
1231 1236
1232 TEST_P(FeatureInfoTest, InitializeARB_vertex_array_object) { 1237 TEST_P(FeatureInfoTest, InitializeARB_vertex_array_object) {
1233 SetupInitExpectations("GL_ARB_vertex_array_object"); 1238 SetupInitExpectations("GL_ARB_vertex_array_object");
1234 EXPECT_THAT(info_->extensions(), 1239 EXPECT_THAT(info_->extensions(),
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
1515 EXPECT_TRUE(info_->validators()->render_buffer_format.IsValid(GL_RG8_EXT)); 1520 EXPECT_TRUE(info_->validators()->render_buffer_format.IsValid(GL_RG8_EXT));
1516 } 1521 }
1517 1522
1518 TEST_P(FeatureInfoTest, InitializeCHROMIUM_ycbcr_422_imageTrue) { 1523 TEST_P(FeatureInfoTest, InitializeCHROMIUM_ycbcr_422_imageTrue) {
1519 SetupInitExpectations("GL_APPLE_ycbcr_422"); 1524 SetupInitExpectations("GL_APPLE_ycbcr_422");
1520 EXPECT_TRUE(info_->feature_flags().chromium_image_ycbcr_422); 1525 EXPECT_TRUE(info_->feature_flags().chromium_image_ycbcr_422);
1521 } 1526 }
1522 1527
1523 } // namespace gles2 1528 } // namespace gles2
1524 } // namespace gpu 1529 } // namespace gpu
OLDNEW
« gpu/command_buffer/service/feature_info.cc ('K') | « gpu/command_buffer/service/feature_info.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698