Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Account for PlzNavigate. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index 3cdf16253289e47b10e578a534d6adf17aacb37b..e9022f0fc84e1fb3926171ff9e43fa51cac114f2 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -180,7 +180,6 @@ FrameLoader::FrameLoader(LocalFrame* frame)
, m_loadType(FrameLoadTypeStandard)
, m_inStopAllLoaders(false)
, m_checkTimer(TaskRunnerHelper::get(TaskType::Networking, frame), this, &FrameLoader::checkTimerFired)
- , m_didAccessInitialDocument(false)
, m_forcedSandboxFlags(SandboxNone)
, m_dispatchingDidClearWindowObjectInMainWorld(false)
, m_protectProvisionalLoader(false)
@@ -1073,10 +1072,8 @@ void FrameLoader::stopAllLoaders()
void FrameLoader::didAccessInitialDocument()
{
- // We only need to notify the client once, and only for the main frame.
- if (isLoadingMainFrame() && !m_didAccessInitialDocument) {
- m_didAccessInitialDocument = true;
-
+ // We only need to notify the client for the main frame.
+ if (isLoadingMainFrame()) {
// Forbid script execution to prevent re-entering V8, since this is
// called from a binding security check.
ScriptForbiddenScope forbidScripts;
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.h ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698