content/renderer/render_frame_impl.h - Issue 2103733004: Set navigationStart correctly for all load types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments, add more tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index c31c3062dab746364c5524c7a7fd10c6f87fc9fb..069e2b89dd2bf1864ff140ce8025cb4255be7f4e 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -527,6 +527,7 @@ class CONTENT_EXPORT RenderFrameImpl

void runScriptsAtDocumentReady(blink::WebLocalFrame* frame,

bool document_is_empty) override;

void didHandleOnloadEvents(blink::WebLocalFrame* frame) override;

+ void didHandleOnBeforeUnloadEvent(bool eventListenerCalled) override;

void didFailLoad(blink::WebLocalFrame* frame,

const blink::WebURLError& error,

blink::WebHistoryCommitType commit_type) override;