Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index f0076ae811104f7e54b8937d483223412fe1669a..efdd217ed6b58c47de943e992ac95fbf565700cb 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -181,7 +181,6 @@ FrameLoader::FrameLoader(LocalFrame* frame)
, m_loadType(FrameLoadTypeStandard)
, m_inStopAllLoaders(false)
, m_checkTimer(TaskRunnerHelper::getLoadingTaskRunner(frame), this, &FrameLoader::checkTimerFired)
- , m_didAccessInitialDocument(false)
, m_forcedSandboxFlags(SandboxNone)
, m_dispatchingDidClearWindowObjectInMainWorld(false)
, m_protectProvisionalLoader(false)
@@ -1077,10 +1076,8 @@ void FrameLoader::stopAllLoaders()
void FrameLoader::didAccessInitialDocument()
{
- // We only need to notify the client once, and only for the main frame.
- if (isLoadingMainFrame() && !m_didAccessInitialDocument) {
- m_didAccessInitialDocument = true;
-
+ // We only need to notify the client for the main frame.
+ if (isLoadingMainFrame()) {
// Forbid script execution to prevent re-entering V8, since this is
// called from a binding security check.
ScriptForbiddenScope forbidScripts;

Powered by Google App Engine
This is Rietveld 408576698