Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't call beforeunload on empty frames. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 1090 matching lines...) Expand 10 before | Expand all | Expand 10 after
1101 1101
1102 // Temporarily holds state pertaining to a navigation that has been initiated 1102 // Temporarily holds state pertaining to a navigation that has been initiated
1103 // until the NavigationState corresponding to the new navigation is created in 1103 // until the NavigationState corresponding to the new navigation is created in
1104 // didCreateDataSource(). 1104 // didCreateDataSource().
1105 std::unique_ptr<NavigationParams> pending_navigation_params_; 1105 std::unique_ptr<NavigationParams> pending_navigation_params_;
1106 1106
1107 // Stores the current history item for this frame, so that updates to it can 1107 // Stores the current history item for this frame, so that updates to it can
1108 // be reported to the browser process via SendUpdateState. 1108 // be reported to the browser process via SendUpdateState.
1109 blink::WebHistoryItem current_history_item_; 1109 blink::WebHistoryItem current_history_item_;
1110 1110
1111 // True if the frame contains the initial document (i.e. has not navigated
1112 // yet) and it has been accessed by another page. Always false after the
1113 // first commit.
1114 bool did_access_initial_document_;
nasko 2016/07/18 22:20:00 Why can't we just expose the bit that is already k
Alexander Semashko 2016/07/19 10:59:07 Indeed. Done.
1115
1111 #if defined(ENABLE_PLUGINS) 1116 #if defined(ENABLE_PLUGINS)
1112 // Current text input composition text. Empty if no composition is in 1117 // Current text input composition text. Empty if no composition is in
1113 // progress. 1118 // progress.
1114 base::string16 pepper_composition_text_; 1119 base::string16 pepper_composition_text_;
1115 1120
1116 PluginPowerSaverHelper* plugin_power_saver_helper_; 1121 PluginPowerSaverHelper* plugin_power_saver_helper_;
1117 1122
1118 PepperPluginInstanceImpl* plugin_find_handler_; 1123 PepperPluginInstanceImpl* plugin_find_handler_;
1119 #endif 1124 #endif
1120 1125
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
1301 mojom::FrameHostPtr frame_host_; 1306 mojom::FrameHostPtr frame_host_;
1302 1307
1303 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1308 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1304 1309
1305 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1310 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1306 }; 1311 };
1307 1312
1308 } // namespace content 1313 } // namespace content
1309 1314
1310 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1315 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698