Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Account for PlzNavigate. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 5414 matching lines...) Expand 10 before | Expand all | Expand 10 after
5425 } 5425 }
5426 5426
5427 class TestAccessInitialDocumentWebFrameClient : public FrameTestHelpers::TestWeb FrameClient { 5427 class TestAccessInitialDocumentWebFrameClient : public FrameTestHelpers::TestWeb FrameClient {
5428 public: 5428 public:
5429 TestAccessInitialDocumentWebFrameClient() : m_didAccessInitialDocument(false ) 5429 TestAccessInitialDocumentWebFrameClient() : m_didAccessInitialDocument(false )
5430 { 5430 {
5431 } 5431 }
5432 5432
5433 virtual void didAccessInitialDocument() 5433 virtual void didAccessInitialDocument()
5434 { 5434 {
5435 EXPECT_TRUE(!m_didAccessInitialDocument);
5436 m_didAccessInitialDocument = true; 5435 m_didAccessInitialDocument = true;
5437 } 5436 }
5438 5437
5439 bool m_didAccessInitialDocument; 5438 bool m_didAccessInitialDocument;
5440 }; 5439 };
5441 5440
5442 TEST_P(ParameterizedWebFrameTest, DidAccessInitialDocumentBody) 5441 TEST_P(ParameterizedWebFrameTest, DidAccessInitialDocumentBody)
5443 { 5442 {
5444 // FIXME: Why is this local webViewClient needed instead of the default 5443 // FIXME: Why is this local webViewClient needed instead of the default
5445 // WebViewHelper one? With out it there's some mysterious crash in the 5444 // WebViewHelper one? With out it there's some mysterious crash in the
(...skipping 3489 matching lines...) Expand 10 before | Expand all | Expand 10 after
8935 FrameTestHelpers::WebViewHelper helper; 8934 FrameTestHelpers::WebViewHelper helper;
8936 helper.initializeAndLoad(url, true); 8935 helper.initializeAndLoad(url, true);
8937 Platform::current()->getURLLoaderMockFactory()->setLoaderDelegate(nullptr); 8936 Platform::current()->getURLLoaderMockFactory()->setLoaderDelegate(nullptr);
8938 8937
8939 Document* document = toLocalFrame(helper.webView()->page()->mainFrame())->do cument(); 8938 Document* document = toLocalFrame(helper.webView()->page()->mainFrame())->do cument();
8940 EXPECT_TRUE(document->isImageDocument()); 8939 EXPECT_TRUE(document->isImageDocument());
8941 EXPECT_EQ(Resource::DecodeError, toImageDocument(document)->cachedImage()->g etStatus()); 8940 EXPECT_EQ(Resource::DecodeError, toImageDocument(document)->cachedImage()->g etStatus());
8942 } 8941 }
8943 8942
8944 } // namespace blink 8943 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698