third_party/WebKit/Source/web/FrameLoaderClientImpl.h - Issue 2103733004: Set navigationStart correctly for all load types.

Side by Side Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.h

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments, add more tests. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/render_view_browsertest.cc ('K') | « third_party/WebKit/Source/core/loader/FrameLoaderClient.h ('k') | third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.

3 * Copyright (C) 2011 Apple Inc. All rights reserved.	3 * Copyright (C) 2011 Apple Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions are	6 * modification, are permitted provided that the following conditions are

7 * met:	7 * met:

8 *	8 *

9 * * Redistributions of source code must retain the above copyright	9 * * Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 71 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
82 Frame* firstChild() const override;	82 Frame* firstChild() const override;

83 Frame* lastChild() const override;	83 Frame* lastChild() const override;

84 void willBeDetached() override;	84 void willBeDetached() override;

85 void detached(FrameDetachType) override;	85 void detached(FrameDetachType) override;

86 void dispatchWillSendRequest(DocumentLoader*, unsigned long identifier, Reso urceRequest&, const ResourceResponse& redirectResponse) override;	86 void dispatchWillSendRequest(DocumentLoader*, unsigned long identifier, Reso urceRequest&, const ResourceResponse& redirectResponse) override;

87 void dispatchDidReceiveResponse(DocumentLoader*, unsigned long identifier, c onst ResourceResponse&) override;	87 void dispatchDidReceiveResponse(DocumentLoader*, unsigned long identifier, c onst ResourceResponse&) override;

88 void dispatchDidChangeResourcePriority(unsigned long identifier, ResourceLoa dPriority, int intraPriorityValue) override;	88 void dispatchDidChangeResourcePriority(unsigned long identifier, ResourceLoa dPriority, int intraPriorityValue) override;

89 void dispatchDidFinishLoading(DocumentLoader*, unsigned long identifier) ove rride;	89 void dispatchDidFinishLoading(DocumentLoader*, unsigned long identifier) ove rride;

90 void dispatchDidLoadResourceFromMemoryCache(const ResourceRequest&, const Re sourceResponse&) override;	90 void dispatchDidLoadResourceFromMemoryCache(const ResourceRequest&, const Re sourceResponse&) override;

91 void dispatchDidHandleOnloadEvents() override;	91 void dispatchDidHandleOnloadEvents() override;

	92 void dispatchDidHandleOnBeforeUnloadEvent(bool eventListenerCalled) override ;

92 void dispatchDidReceiveServerRedirectForProvisionalLoad() override;	93 void dispatchDidReceiveServerRedirectForProvisionalLoad() override;

93 void dispatchDidNavigateWithinPage(HistoryItem*, HistoryCommitType, bool con tentInitiated) override;	94 void dispatchDidNavigateWithinPage(HistoryItem*, HistoryCommitType, bool con tentInitiated) override;

94 void dispatchWillClose() override;	95 void dispatchWillClose() override;

95 void dispatchDidStartProvisionalLoad(double triggeringEventTime) override;	96 void dispatchDidStartProvisionalLoad(double triggeringEventTime) override;

96 void dispatchDidReceiveTitle(const String&) override;	97 void dispatchDidReceiveTitle(const String&) override;

97 void dispatchDidChangeIcons(IconType) override;	98 void dispatchDidChangeIcons(IconType) override;

98 void dispatchDidCommitLoad(HistoryItem*, HistoryCommitType) override;	99 void dispatchDidCommitLoad(HistoryItem*, HistoryCommitType) override;

99 void dispatchDidFailProvisionalLoad(const ResourceError&, HistoryCommitType) override;	100 void dispatchDidFailProvisionalLoad(const ResourceError&, HistoryCommitType) override;

100 void dispatchDidFailLoad(const ResourceError&, HistoryCommitType) override;	101 void dispatchDidFailLoad(const ResourceError&, HistoryCommitType) override;

101 void dispatchDidFinishDocumentLoad() override;	102 void dispatchDidFinishDocumentLoad() override;

(...skipping 92 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
194 Member<WebLocalFrameImpl> m_webFrame;	195 Member<WebLocalFrameImpl> m_webFrame;

195	196

196 String m_userAgent;	197 String m_userAgent;

197 };	198 };

198	199

199 DEFINE_TYPE_CASTS(FrameLoaderClientImpl, FrameLoaderClient, client, client->isFr ameLoaderClientImpl(), client.isFrameLoaderClientImpl());	200 DEFINE_TYPE_CASTS(FrameLoaderClientImpl, FrameLoaderClient, client, client->isFr ameLoaderClientImpl(), client.isFrameLoaderClientImpl());

200	201

201 } // namespace blink	202 } // namespace blink

202	203

203 #endif	204 #endif

OLD	NEW