Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments, add more tests. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 509 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 blink::WebLocalFrame* frame) override; 520 blink::WebLocalFrame* frame) override;
521 void didReceiveTitle(blink::WebLocalFrame* frame, 521 void didReceiveTitle(blink::WebLocalFrame* frame,
522 const blink::WebString& title, 522 const blink::WebString& title,
523 blink::WebTextDirection direction) override; 523 blink::WebTextDirection direction) override;
524 void didChangeIcon(blink::WebLocalFrame* frame, 524 void didChangeIcon(blink::WebLocalFrame* frame,
525 blink::WebIconURL::Type icon_type) override; 525 blink::WebIconURL::Type icon_type) override;
526 void didFinishDocumentLoad(blink::WebLocalFrame* frame) override; 526 void didFinishDocumentLoad(blink::WebLocalFrame* frame) override;
527 void runScriptsAtDocumentReady(blink::WebLocalFrame* frame, 527 void runScriptsAtDocumentReady(blink::WebLocalFrame* frame,
528 bool document_is_empty) override; 528 bool document_is_empty) override;
529 void didHandleOnloadEvents(blink::WebLocalFrame* frame) override; 529 void didHandleOnloadEvents(blink::WebLocalFrame* frame) override;
530 void didHandleOnBeforeUnloadEvent(bool eventListenerCalled) override;
530 void didFailLoad(blink::WebLocalFrame* frame, 531 void didFailLoad(blink::WebLocalFrame* frame,
531 const blink::WebURLError& error, 532 const blink::WebURLError& error,
532 blink::WebHistoryCommitType commit_type) override; 533 blink::WebHistoryCommitType commit_type) override;
533 void didFinishLoad(blink::WebLocalFrame* frame) override; 534 void didFinishLoad(blink::WebLocalFrame* frame) override;
534 void didNavigateWithinPage(blink::WebLocalFrame* frame, 535 void didNavigateWithinPage(blink::WebLocalFrame* frame,
535 const blink::WebHistoryItem& item, 536 const blink::WebHistoryItem& item,
536 blink::WebHistoryCommitType commit_type, 537 blink::WebHistoryCommitType commit_type,
537 bool content_initiated) override; 538 bool content_initiated) override;
538 void didUpdateCurrentHistoryItem() override; 539 void didUpdateCurrentHistoryItem() override;
539 void didChangeThemeColor() override; 540 void didChangeThemeColor() override;
(...skipping 758 matching lines...) Expand 10 before | Expand all | Expand 10 after
1298 mojom::FrameHostPtr frame_host_; 1299 mojom::FrameHostPtr frame_host_;
1299 1300
1300 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1301 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1301 1302
1302 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1303 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1303 }; 1304 };
1304 1305
1305 } // namespace content 1306 } // namespace content
1306 1307
1307 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1308 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698