Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Side by Side Diff: third_party/WebKit/public/web/WebLocalFrame.h

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebLocalFrame_h 5 #ifndef WebLocalFrame_h
6 #define WebLocalFrame_h 6 #define WebLocalFrame_h
7 7
8 #include "WebFrame.h" 8 #include "WebFrame.h"
9 #include "WebFrameLoadType.h" 9 #include "WebFrameLoadType.h"
10 10
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 // * CSP policy block 126 // * CSP policy block
127 // * reload 127 // * reload
128 // * form submission 128 // * form submission
129 virtual bool isNavigationScheduledWithin(double intervalInSeconds) const = 0 ; 129 virtual bool isNavigationScheduledWithin(double intervalInSeconds) const = 0 ;
130 130
131 // Override the normal rules for whether a load has successfully committed 131 // Override the normal rules for whether a load has successfully committed
132 // in this frame. Used to propagate state when this frame has navigated 132 // in this frame. Used to propagate state when this frame has navigated
133 // cross process. 133 // cross process.
134 virtual void setCommittedFirstRealLoad() = 0; 134 virtual void setCommittedFirstRealLoad() = 0;
135 135
136 // Returns true if this is the main frame and its initial document has been
137 // accessed (see also WebFrameClient::didAccessInitialDocument).
138 virtual bool hasAccessedInitialDocument() const = 0;
dcheng 2016/07/29 12:50:53 Can't we just track this bit in RenderFrameImpl ra
Alexander Semashko 2016/08/12 09:26:34 Done.
139
136 // Orientation Changes ---------------------------------------------------- 140 // Orientation Changes ----------------------------------------------------
137 141
138 // Notify the frame that the screen orientation has changed. 142 // Notify the frame that the screen orientation has changed.
139 virtual void sendOrientationChangeEvent() = 0; 143 virtual void sendOrientationChangeEvent() = 0;
140 144
141 145
142 // Printing ------------------------------------------------------------ 146 // Printing ------------------------------------------------------------
143 147
144 // Returns true on success and sets the out parameter to the print preset op tions for the document. 148 // Returns true on success and sets the out parameter to the print preset op tions for the document.
145 virtual bool getPrintPresetOptionsForPlugin(const WebNode&, WebPrintPresetOp tions*) = 0; 149 virtual bool getPrintPresetOptionsForPlugin(const WebNode&, WebPrintPresetOp tions*) = 0;
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 // to call these on a WebLocalFrame. 432 // to call these on a WebLocalFrame.
429 bool isWebLocalFrame() const override = 0; 433 bool isWebLocalFrame() const override = 0;
430 WebLocalFrame* toWebLocalFrame() override = 0; 434 WebLocalFrame* toWebLocalFrame() override = 0;
431 bool isWebRemoteFrame() const override = 0; 435 bool isWebRemoteFrame() const override = 0;
432 WebRemoteFrame* toWebRemoteFrame() override = 0; 436 WebRemoteFrame* toWebRemoteFrame() override = 0;
433 }; 437 };
434 438
435 } // namespace blink 439 } // namespace blink
436 440
437 #endif // WebLocalFrame_h 441 #endif // WebLocalFrame_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698