Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment, fix indent. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 WebURLRequest requestForReload(WebFrameLoadType, const WebURL&) const overri de; 209 WebURLRequest requestForReload(WebFrameLoadType, const WebURL&) const overri de;
210 void load(const WebURLRequest&, WebFrameLoadType, const WebHistoryItem&, 210 void load(const WebURLRequest&, WebFrameLoadType, const WebHistoryItem&,
211 WebHistoryLoadType, bool isClientRedirect) override; 211 WebHistoryLoadType, bool isClientRedirect) override;
212 void loadData( 212 void loadData(
213 const WebData&, const WebString& mimeType, const WebString& textEncoding , 213 const WebData&, const WebString& mimeType, const WebString& textEncoding ,
214 const WebURL& baseURL, const WebURL& unreachableURL, bool replace, WebFr ameLoadType, 214 const WebURL& baseURL, const WebURL& unreachableURL, bool replace, WebFr ameLoadType,
215 const WebHistoryItem&, WebHistoryLoadType, bool isClientRedirect) overri de; 215 const WebHistoryItem&, WebHistoryLoadType, bool isClientRedirect) overri de;
216 bool isLoading() const override; 216 bool isLoading() const override;
217 bool isNavigationScheduledWithin(double interval) const override; 217 bool isNavigationScheduledWithin(double interval) const override;
218 void setCommittedFirstRealLoad() override; 218 void setCommittedFirstRealLoad() override;
219 bool getDidAccessInitialDocument() const override;
219 void sendOrientationChangeEvent() override; 220 void sendOrientationChangeEvent() override;
220 void willShowInstallBannerPrompt(int requestId, const WebVector<WebString>& platforms, WebAppBannerPromptReply*) override; 221 void willShowInstallBannerPrompt(int requestId, const WebVector<WebString>& platforms, WebAppBannerPromptReply*) override;
221 WebSandboxFlags effectiveSandboxFlags() const override; 222 WebSandboxFlags effectiveSandboxFlags() const override;
222 void forceSandboxFlags(WebSandboxFlags) override; 223 void forceSandboxFlags(WebSandboxFlags) override;
223 void requestRunTask(WebSuspendableTask*) const override; 224 void requestRunTask(WebSuspendableTask*) const override;
224 void didCallAddSearchProvider() override; 225 void didCallAddSearchProvider() override;
225 void didCallIsSearchProviderInstalled() override; 226 void didCallIsSearchProviderInstalled() override;
226 void replaceSelection(const WebString&) override; 227 void replaceSelection(const WebString&) override;
227 bool find( 228 bool find(
228 int identifier, const WebString& searchText, const WebFindOptions&, 229 int identifier, const WebString& searchText, const WebFindOptions&,
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 // Accomplish that by keeping a self-referential Persistent<>. It is 397 // Accomplish that by keeping a self-referential Persistent<>. It is
397 // cleared upon close(). 398 // cleared upon close().
398 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive; 399 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive;
399 }; 400 };
400 401
401 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame()); 402 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame());
402 403
403 } // namespace blink 404 } // namespace blink
404 405
405 #endif 406 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698