Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 425 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 if (m_webFrame->client()) 436 if (m_webFrame->client())
437 m_webFrame->client()->didLoadResourceFromMemoryCache(WrappedResourceRequ est(request), WrappedResourceResponse(response)); 437 m_webFrame->client()->didLoadResourceFromMemoryCache(WrappedResourceRequ est(request), WrappedResourceResponse(response));
438 } 438 }
439 439
440 void FrameLoaderClientImpl::dispatchDidHandleOnloadEvents() 440 void FrameLoaderClientImpl::dispatchDidHandleOnloadEvents()
441 { 441 {
442 if (m_webFrame->client()) 442 if (m_webFrame->client())
443 m_webFrame->client()->didHandleOnloadEvents(m_webFrame); 443 m_webFrame->client()->didHandleOnloadEvents(m_webFrame);
444 } 444 }
445 445
446 void FrameLoaderClientImpl::dispatchDidHandleOnBeforeUnloadEvent(bool eventListe nerCalled)
447 {
448 if (m_webFrame->client())
449 m_webFrame->client()->didHandleOnBeforeUnloadEvent(eventListenerCalled);
450 }
451
446 void FrameLoaderClientImpl::dispatchDidReceiveServerRedirectForProvisionalLoad() 452 void FrameLoaderClientImpl::dispatchDidReceiveServerRedirectForProvisionalLoad()
447 { 453 {
448 if (m_webFrame->client()) 454 if (m_webFrame->client())
449 m_webFrame->client()->didReceiveServerRedirectForProvisionalLoad(m_webFr ame); 455 m_webFrame->client()->didReceiveServerRedirectForProvisionalLoad(m_webFr ame);
450 } 456 }
451 457
452 void FrameLoaderClientImpl::dispatchDidNavigateWithinPage(HistoryItem* item, His toryCommitType commitType, bool contentInitiated) 458 void FrameLoaderClientImpl::dispatchDidNavigateWithinPage(HistoryItem* item, His toryCommitType commitType, bool contentInitiated)
453 { 459 {
454 bool shouldCreateHistoryEntry = commitType == StandardCommit; 460 bool shouldCreateHistoryEntry = commitType == StandardCommit;
455 // TODO(dglazkov): Does this need to be called for subframes? 461 // TODO(dglazkov): Does this need to be called for subframes?
(...skipping 575 matching lines...) Expand 10 before | Expand all | Expand 10 after
1031 } 1037 }
1032 1038
1033 WebEffectiveConnectionType FrameLoaderClientImpl::getEffectiveConnectionType() 1039 WebEffectiveConnectionType FrameLoaderClientImpl::getEffectiveConnectionType()
1034 { 1040 {
1035 if (m_webFrame->client()) 1041 if (m_webFrame->client())
1036 return m_webFrame->client()->getEffectiveConnectionType(); 1042 return m_webFrame->client()->getEffectiveConnectionType();
1037 return WebEffectiveConnectionType::TypeUnknown; 1043 return WebEffectiveConnectionType::TypeUnknown;
1038 } 1044 }
1039 1045
1040 } // namespace blink 1046 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698