Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2103733002: Handle WebContents going away in content settings bubbles. (Closed)

Created:
4 years, 5 months ago by benwells
Modified:
4 years, 5 months ago
Reviewers:
felt
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle WebContents going away in content settings bubbles. This fixes null dereference crashes when tabs close with open bubbles. BUG=622973 Committed: https://crrev.com/6ca90e6b157c59c0556bff78b9e0ad81bf1e3aae Cr-Commit-Position: refs/heads/master@{#402610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 5 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
benwells
4 years, 5 months ago (2016-06-28 08:34:56 UTC) #2
felt
lgtm
4 years, 5 months ago (2016-06-28 23:35:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103733002/1
4 years, 5 months ago (2016-06-28 23:43:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 00:16:22 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 00:18:10 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6ca90e6b157c59c0556bff78b9e0ad81bf1e3aae
Cr-Commit-Position: refs/heads/master@{#402610}

Powered by Google App Engine
This is Rietveld 408576698