Issue 2103703004: Always use FrameNavigationDisabler during DocumentLoader detach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2103703004: Always use FrameNavigationDisabler during DocumentLoader detach. (Closed)

Created:
4 years, 5 months ago by Nate Chapin

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

More Reviews

Description

Always use FrameNavigationDisabler during DocumentLoader detach. BUG=617495 Review-Url: https://codereview.chromium.org/2079473002 Cr-Commit-Position: refs/heads/master@{#400558} (cherry picked from commit be655fd4fb9ab3291a855a939496111674037a2f)

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	third_party/WebKit/Source/core/loader/FrameLoader.cpp	View		3 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nate Chapin

4 years, 5 months ago (2016-07-20 23:19:08 UTC) #1

Description was changed from

==========
Always use FrameNavigationDisabler during DocumentLoader detach.

BUG=617495

Review-Url: https://codereview.chromium.org/2079473002
Cr-Commit-Position: refs/heads/master@{#400558}
(cherry picked from commit be655fd4fb9ab3291a855a939496111674037a2f)
==========

to

==========
Always use FrameNavigationDisabler during DocumentLoader detach.

BUG=617495

Review-Url: https://codereview.chromium.org/2079473002
Cr-Commit-Position: refs/heads/master@{#400558}
(cherry picked from commit be655fd4fb9ab3291a855a939496111674037a2f)
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages