Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2103693006: [ios] New icons for the Omnibox. (Closed)

Created:
4 years, 5 months ago by palmer
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] New icons for the Omnibox. BUG=604520 Committed: https://crrev.com/40a4da5f6cab39476785fc27d193eaa9d175a96b Cr-Commit-Position: refs/heads/master@{#402869}

Patch Set 1 #

Messages

Total messages: 15 (6 generated)
rohitrao (ping after 24h)
LGTM whenever you're ready to submit this Is this for M53, or do you want ...
4 years, 5 months ago (2016-06-28 21:32:18 UTC) #2
palmer
> Is this for M53, or do you want to hold it until after branch? ...
4 years, 5 months ago (2016-06-28 21:40:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103693006/1
4 years, 5 months ago (2016-06-28 21:42:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/208902)
4 years, 5 months ago (2016-06-28 22:19:35 UTC) #7
palmer
sdefresne: Can you please take a look? This CL goes along with https://chromereviews.googleplex.com/453287014.
4 years, 5 months ago (2016-06-28 22:39:49 UTC) #9
sdefresne
lgtm
4 years, 5 months ago (2016-06-29 07:35:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103693006/1
4 years, 5 months ago (2016-06-29 17:59:27 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 18:12:06 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 18:15:41 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40a4da5f6cab39476785fc27d193eaa9d175a96b
Cr-Commit-Position: refs/heads/master@{#402869}

Powered by Google App Engine
This is Rietveld 408576698