Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: components/safe_browsing_db/v4_update_protocol_manager.h

Issue 2103693002: SafeBrowsing PVer4: Send mutable response to the database and the stores (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_ReadFromDisk
Patch Set: Minor: Add the explicit keyword for UpdateListIdentifier constructor Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_update_protocol_manager.h
diff --git a/components/safe_browsing_db/v4_update_protocol_manager.h b/components/safe_browsing_db/v4_update_protocol_manager.h
index 20f18ee893b485e6fd2ca2bbe147210f275dbd18..a8c1624b82dfdf3fd0ba6e029f7d9fa13f01b416 100644
--- a/components/safe_browsing_db/v4_update_protocol_manager.h
+++ b/components/safe_browsing_db/v4_update_protocol_manager.h
@@ -41,7 +41,7 @@ class V4UpdateProtocolManagerFactory;
// Parameters:
// - The vector of update response protobufs received from the server for
// each list type.
-typedef base::Callback<void(const std::vector<ListUpdateResponse>&)>
+typedef base::Callback<void(std::unique_ptr<ParsedServerResponse>)>
V4UpdateCallback;
class V4UpdateProtocolManager : public net::URLFetcherDelegate,
@@ -106,9 +106,8 @@ class V4UpdateProtocolManager : public net::URLFetcherDelegate,
// FetchThreatListUpdatesResponse protobuf and returns each of the
// ListUpdateResponse protobufs contained in it as a vector.
// Returns true if parsing is successful, false otherwise.
- bool ParseUpdateResponse(
- const std::string& data_base64,
- std::vector<ListUpdateResponse>* list_update_responses);
+ bool ParseUpdateResponse(const std::string& data_base64,
+ ParsedServerResponse* parsed_server_response);
// Resets the update error counter and multiplier.
void ResetUpdateErrors();
« no previous file with comments | « components/safe_browsing_db/v4_store_unittest.cc ('k') | components/safe_browsing_db/v4_update_protocol_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698