Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: components/safe_browsing_db/v4_protocol_manager_util.h

Issue 2103693002: SafeBrowsing PVer4: Send mutable response to the database and the stores (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_ReadFromDisk
Patch Set: Minor: Add the explicit keyword for UpdateListIdentifier constructor Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing_db/v4_local_database_manager.cc ('k') | components/safe_browsing_db/v4_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/v4_protocol_manager_util.h
diff --git a/components/safe_browsing_db/v4_protocol_manager_util.h b/components/safe_browsing_db/v4_protocol_manager_util.h
index 7b510de3dedf59396fa290aebdfe411106bfd1b5..6b81e8b5c0bf5703aded8ee36d5e1c0bb47b20a3 100644
--- a/components/safe_browsing_db/v4_protocol_manager_util.h
+++ b/components/safe_browsing_db/v4_protocol_manager_util.h
@@ -58,7 +58,7 @@ struct UpdateListIdentifier {
ThreatType threat_type;
UpdateListIdentifier(PlatformType, ThreatEntryType, ThreatType);
- UpdateListIdentifier(const ListUpdateResponse&);
+ explicit UpdateListIdentifier(const ListUpdateResponse&);
bool operator==(const UpdateListIdentifier& other) const;
bool operator!=(const UpdateListIdentifier& other) const;
@@ -82,6 +82,9 @@ typedef base::hash_map<UpdateListIdentifier, std::string> StoreFileNameMap;
// Represents the state of each store.
typedef base::hash_map<UpdateListIdentifier, std::string> StoreStateMap;
+// Sever response, parsed in vector form.
+typedef std::vector<std::unique_ptr<ListUpdateResponse>> ParsedServerResponse;
+
// Enumerate failures for histogramming purposes. DO NOT CHANGE THE
// ORDERING OF THESE VALUES.
enum V4OperationResult {
« no previous file with comments | « components/safe_browsing_db/v4_local_database_manager.cc ('k') | components/safe_browsing_db/v4_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698