components/safe_browsing_db/v4_protocol_manager_util.h - Issue 2103693002: SafeBrowsing PVer4: Send mutable response to the database and the stores

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_protocol_manager_util.h

Issue 2103693002: SafeBrowsing PVer4: Send mutable response to the database and the stores (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_ReadFromDisk

Patch Set: git pull Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/safe_browsing_db/v4_local_database_manager.cc ('k') | components/safe_browsing_db/v4_protocol_manager_util.cc » ('j') | components/safe_browsing_db/v4_update_protocol_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_protocol_manager_util.h

diff --git a/components/safe_browsing_db/v4_protocol_manager_util.h b/components/safe_browsing_db/v4_protocol_manager_util.h

index 7b510de3dedf59396fa290aebdfe411106bfd1b5..5f0469543df5f4b33a378d8a859510abe9d6176b 100644

--- a/components/safe_browsing_db/v4_protocol_manager_util.h

+++ b/components/safe_browsing_db/v4_protocol_manager_util.h

@@ -58,7 +58,7 @@ struct UpdateListIdentifier {

ThreatType threat_type;

UpdateListIdentifier(PlatformType, ThreatEntryType, ThreatType);

- UpdateListIdentifier(const ListUpdateResponse&);

+ UpdateListIdentifier(const ListUpdateResponse*);

bool operator==(const UpdateListIdentifier& other) const;

bool operator!=(const UpdateListIdentifier& other) const;

@@ -82,6 +82,9 @@ typedef base::hash_map<UpdateListIdentifier, std::string> StoreFileNameMap;

// Represents the state of each store.

typedef base::hash_map<UpdateListIdentifier, std::string> StoreStateMap;

+// Sever response, parsed in vector form.

+typedef std::vector<std::unique_ptr<ListUpdateResponse>> ParsedServerResponse;

// Enumerate failures for histogramming purposes. DO NOT CHANGE THE

// ORDERING OF THESE VALUES.

enum V4OperationResult {