SafeBrowsing PVer4: Send mutable response to the database and the stores

components/safe_browsing_db/v4_store_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
+#include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/time/time.h"
 #include "components/safe_browsing_db/v4_store.h"
 #include "components/safe_browsing_db/v4_store.pb.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/platform_test.h"
 
 namespace safe_browsing {
 
@@ skipping 89 matching lines @@
 }
 
 TEST_F(V4StoreTest, TestReadFromNoHashPrefixesFile) {
   ListUpdateResponse list_update_response;
   list_update_response.set_platform_type(LINUX_PLATFORM);
   WriteFileFormatProtoToFile(0x600D71FE, 9, &list_update_response);
   EXPECT_EQ(READ_SUCCESS, V4Store(task_runner_, store_path_).ReadFromDisk());
 }
 
 TEST_F(V4StoreTest, TestWriteNoResponseType) {
-  ListUpdateResponse list_update_response;
-  EXPECT_EQ(
-      INVALID_RESPONSE_TYPE_FAILURE,
-      V4Store(task_runner_, store_path_).WriteToDisk(list_update_response));
+  EXPECT_EQ(INVALID_RESPONSE_TYPE_FAILURE,
+            V4Store(task_runner_, store_path_)
+                .WriteToDisk(base::WrapUnique(new ListUpdateResponse)));
 }
 
 TEST_F(V4StoreTest, TestWritePartialResponseType) {
-  ListUpdateResponse list_update_response;
-  list_update_response.set_response_type(ListUpdateResponse::PARTIAL_UPDATE);
-  EXPECT_EQ(
-      INVALID_RESPONSE_TYPE_FAILURE,
-      V4Store(task_runner_, store_path_).WriteToDisk(list_update_response));
+  ListUpdateResponse* list_update_response = new ListUpdateResponse;

[Scott Hess - ex-Googler, 2016/06/28 03:58:43]

This leaves the pointer unowned for a bit.  Instead this should be the
unique_ptr, with std::move() at the write.

[vakh (use Gerrit instead), 2016/06/28 21:34:14]

Done.

+  list_update_response->set_response_type(ListUpdateResponse::PARTIAL_UPDATE);
+  EXPECT_EQ(INVALID_RESPONSE_TYPE_FAILURE,
+            V4Store(task_runner_, store_path_)
+                .WriteToDisk(base::WrapUnique(list_update_response)));
 }
 
 TEST_F(V4StoreTest, TestWriteFullResponseType) {
-  ListUpdateResponse list_update_response;
-  list_update_response.set_response_type(ListUpdateResponse::FULL_UPDATE);
-  list_update_response.set_new_client_state("test_client_state");
+  ListUpdateResponse* list_update_response = new ListUpdateResponse;

[Scott Hess - ex-Googler, 2016/06/28 03:58:43]

Likewise here.

[vakh (use Gerrit instead), 2016/06/28 21:34:14]

Done.

+  list_update_response->set_response_type(ListUpdateResponse::FULL_UPDATE);
+  list_update_response->set_new_client_state("test_client_state");
   V4Store* write_store = new V4Store(task_runner_, store_path_);
-  EXPECT_EQ(WRITE_SUCCESS, write_store->WriteToDisk(list_update_response));
+  EXPECT_EQ(WRITE_SUCCESS,
+            write_store->WriteToDisk(base::WrapUnique(list_update_response)));
 
   V4Store* read_store = new V4Store(task_runner_, store_path_);
   EXPECT_EQ(READ_SUCCESS, read_store->ReadFromDisk());
   EXPECT_EQ("test_client_state", read_store->state_);
 }
 
 }  // namespace safe_browsing