Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: tools/android/loading/tracing.py

Issue 2103673003: tools/android/loading: Properly detect page loading failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Colin's nit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/android/loading/request_track_unittest.py ('k') | tools/android/loading/tracing_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/loading/tracing.py
diff --git a/tools/android/loading/tracing.py b/tools/android/loading/tracing.py
index 3bf5246fc7e865f0a2cfd0d036e98176756d352d..f69392da78f98b363b2246c3729bd25ea3eb9bd4 100644
--- a/tools/android/loading/tracing.py
+++ b/tools/android/loading/tracing.py
@@ -86,6 +86,13 @@ class TracingTrack(devtools_monitor.Track):
return [e for e in matching_events
if 'frame' in e.args and e.args['frame'] == self.GetMainFrameID()]
+ def GetMainFrameRoutingID(self):
+ """Returns the main frame routing ID."""
+ for event in self.GetMatchingEvents(
+ 'navigation', 'RenderFrameImpl::OnNavigate'):
+ return event.args['id']
+ assert False
+
def GetMainFrameID(self):
"""Returns the main frame ID."""
if not self._main_frame_id:
@@ -225,6 +232,19 @@ class TracingTrack(devtools_monitor.Track):
self._IndexEvents()
return self._interval_tree.GetEvents()
+ def HasLoadingSucceeded(self):
+ """Returns whether the loading has succeed at recording time."""
+ main_frame_id = self.GetMainFrameRoutingID()
+ for event in self.GetMatchingEvents(
+ 'navigation', 'RenderFrameImpl::didFailProvisionalLoad'):
+ if event.args['id'] == main_frame_id:
+ return False
+ for event in self.GetMatchingEvents(
+ 'navigation', 'RenderFrameImpl::didFailLoad'):
+ if event.args['id'] == main_frame_id:
+ return False
+ return True
+
class _SpanningEvents(object):
def __init__(self):
self._duration_stack = []
« no previous file with comments | « tools/android/loading/request_track_unittest.py ('k') | tools/android/loading/tracing_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698