Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: gclient.py

Issue 2103663004: Slight fix for gclient readability (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index 9bc21e5a5535afd2a6a322c628d07157dc7b9f72..a1d6f2e0015ecc82b0b2e38dfaa29d56a6ec57f6 100755
--- a/gclient.py
+++ b/gclient.py
@@ -1481,11 +1481,11 @@ been automagically updated. The previous version is available at %s.old.
return revision_overrides
solutions_names = [s.name for s in self.dependencies]
for i, revision in enumerate(self._options.revisions):
- if not '@' in revision:
+ if '@' in revision:
+ name, rev = revision.split('@', 1)
+ else:
# Support for --revision 123
name, rev = solutions_names[i], revision
- else:
- name, rev = revision.split('@', 1)
revision_overrides[name] = rev
return revision_overrides
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698