Revert of MD Settings: make chrome://[md-]settings/clearBrowserData URL work

Revert of MD Settings: make chrome://[md-]settings/clearBrowserData URL work (patchset #7 id:120001 of https://codereview.chromium.org/2094223004/ )

Reason for revert:
Looks like this is causing CrSettingsPrivacyPageTest.PrivacyPage to fail on Mac10.9 and Mac ASAN

Original issue's description:
> MD Settings: make chrome://[md-]settings/clearBrowserData URL work
>
> R=michaelpg@chromium.org
> BUG=622037
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/a6ecac07f74cf819dc164bb91f721e596c261cd2
> Cr-Commit-Position: refs/heads/master@{#402614}

TBR=michaelpg@chromium.org,dbeam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622037
Committed: https://crrev.com/6000aea80c445f9932dcdbbe53d8f963f7a3182f
Cr-Commit-Position: refs/heads/master@{#402651}

[shans, 2016-06-29 01:48:01]

The CQ bit was checked by shans@chromium.org

[shans, 2016-06-29 01:48:01]

Created Revert of MD Settings: make chrome://[md-]settings/clearBrowserData URL
work

[commit-bot: I haz the power, 2016-06-29 01:50:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-06-29 01:54:40]

lgtm but :'(

dbeam, can you poke at this some more?

https://codereview.chromium.org/2103653004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.js (left):

https://codereview.chromium.org/2103653004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.js:43:
settings.main.rendered.then(function() {
Haha, I guess that's what happens when you suppress missing properties :-P

[16721:1287:0628/183642:ERROR:CONSOLE(44)] "Mocha test failed:
NativeCertificateManager "before each" hook
Error: Uncaught TypeError: Cannot read property 'rendered' of undefined
(privacy_page.js:43)
    at Context.<anonymous> (privacy_page_test.js:78:23)
", source: mocha_adapter.js (44)

privacy_page_test.js (via cr_settings_browsertest.js) loads privacy_page.html
which of course doesn't import settings-main, so this fails

[commit-bot: I haz the power, 2016-06-29 02:00:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 02:02:45]

Description was changed from

==========
Revert of MD Settings: make chrome://[md-]settings/clearBrowserData URL work
(patchset #7 id:120001 of https://codereview.chromium.org/2094223004/ )

Reason for revert:
Looks like this is causing CrSettingsPrivacyPageTest.PrivacyPage to fail on
Mac10.9 and Mac ASAN

Original issue's description:
> MD Settings: make chrome://[md-]settings/clearBrowserData URL work
> 
> R=michaelpg@chromium.org
> BUG=622037
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
> 
> Committed: https://crrev.com/a6ecac07f74cf819dc164bb91f721e596c261cd2
> Cr-Commit-Position: refs/heads/master@{#402614}

TBR=michaelpg@chromium.org,dbeam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622037
==========

to

==========
Revert of MD Settings: make chrome://[md-]settings/clearBrowserData URL work
(patchset #7 id:120001 of https://codereview.chromium.org/2094223004/ )

Reason for revert:
Looks like this is causing CrSettingsPrivacyPageTest.PrivacyPage to fail on
Mac10.9 and Mac ASAN

Original issue's description:
> MD Settings: make chrome://[md-]settings/clearBrowserData URL work
>
> R=michaelpg@chromium.org
> BUG=622037
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/a6ecac07f74cf819dc164bb91f721e596c261cd2
> Cr-Commit-Position: refs/heads/master@{#402614}

TBR=michaelpg@chromium.org,dbeam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622037

Committed: https://crrev.com/6000aea80c445f9932dcdbbe53d8f963f7a3182f
Cr-Commit-Position: refs/heads/master@{#402651}
==========

[commit-bot: I haz the power, 2016-06-29 02:02:47]

Patchset 1 (id:??) landed as
https://crrev.com/6000aea80c445f9932dcdbbe53d8f963f7a3182f
Cr-Commit-Position: refs/heads/master@{#402651}

[Dan Beam, 2016-06-29 20:42:50]

https://codereview.chromium.org/2103653004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.js (left):

https://codereview.chromium.org/2103653004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.js:43:
settings.main.rendered.then(function() {
On 2016/06/29 01:54:40, michaelpg wrote:
> Haha, I guess that's what happens when you suppress missing properties :-P

tests aren't compiled

> 
> [16721:1287:0628/183642:ERROR:CONSOLE(44)] "Mocha test failed:
> NativeCertificateManager "before each" hook
> Error: Uncaught TypeError: Cannot read property 'rendered' of undefined
> (privacy_page.js:43)
>     at Context.<anonymous> (privacy_page_test.js:78:23)
> ", source: mocha_adapter.js (44)
> 
> privacy_page_test.js (via cr_settings_browsertest.js) loads privacy_page.html
> which of course doesn't import settings-main, so this fails

our we just not running our tests on try runs?  this is like the second or third
time something hasn't been caught by the try bots.

[Dan Beam, 2016-06-29 20:42:59]

On 2016/06/29 20:42:50, Dan Beam wrote:
>
https://codereview.chromium.org/2103653004/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/privacy_page/privacy_page.js (left):
> 
>
https://codereview.chromium.org/2103653004/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/privacy_page/privacy_page.js:43:
> settings.main.rendered.then(function() {
> On 2016/06/29 01:54:40, michaelpg wrote:
> > Haha, I guess that's what happens when you suppress missing properties :-P
> 
> tests aren't compiled
> 
> > 
> > [16721:1287:0628/183642:ERROR:CONSOLE(44)] "Mocha test failed:
> > NativeCertificateManager "before each" hook
> > Error: Uncaught TypeError: Cannot read property 'rendered' of undefined
> > (privacy_page.js:43)
> >     at Context.<anonymous> (privacy_page_test.js:78:23)
> > ", source: mocha_adapter.js (44)
> > 
> > privacy_page_test.js (via cr_settings_browsertest.js) loads
privacy_page.html
> > which of course doesn't import settings-main, so this fails
> 
> our we just not running our tests on try runs?  this is like the second or
third
> time something hasn't been caught by the try bots.

are we just*

[michaelpg, 2016-06-29 21:03:30]

https://codereview.chromium.org/2103653004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.js (left):

https://codereview.chromium.org/2103653004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.js:43:
settings.main.rendered.then(function() {
On 2016/06/29 20:42:49, Dan Beam wrote:
> On 2016/06/29 01:54:40, michaelpg wrote:
> > Haha, I guess that's what happens when you suppress missing properties :-P
> 
> tests aren't compiled

I didn't mean to imply causality per se. "And that's why you don't suppress
closure warnings."

> 
> > 
> > [16721:1287:0628/183642:ERROR:CONSOLE(44)] "Mocha test failed:
> > NativeCertificateManager "before each" hook
> > Error: Uncaught TypeError: Cannot read property 'rendered' of undefined
> > (privacy_page.js:43)
> >     at Context.<anonymous> (privacy_page_test.js:78:23)
> > ", source: mocha_adapter.js (44)
> > 
> > privacy_page_test.js (via cr_settings_browsertest.js) loads
privacy_page.html
> > which of course doesn't import settings-main, so this fails
> 
> our we just not running our tests on try runs?  this is like the second or
third
> time something hasn't been caught by the try bots.