Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issue 210363006: Add a constructor to TextIterator taking two Positions as iteration range. (Closed)

Created:
6 years, 9 months ago by Yuta Kitamura
Modified:
6 years, 9 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, hayato
Visibility:
Public.

Description

Add a constructor to TextIterator taking two Positions as iteration range. This refactoring patch is a step towards fixing a bug in the find-in-page functionality. To fix the issue, we need a way to pass a document range which may span multiple TreeScopes to findPlainText() (and eventually TextIterator). Currently it takes a Range, which does not support this kind of document ranges. This patch introduces an overloaded constructor of TextIterator taking two Positions instead of a Range. The core routine of the old constructor is moved to a private member function so that it can be shared with different constructors. This patch also moves some obvious initialization of member variables in the constructor body to the initializer list. No behavior change expected. BUG=353430 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170002

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -26 lines) Patch
M Source/core/editing/TextIterator.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 2 chunks +64 lines, -26 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Yuta Kitamura
6 years, 9 months ago (2014-03-25 10:02:59 UTC) #1
yosin_UTC9
LGTM! This patch is so cool and I'm excited. This patch gives us practical example ...
6 years, 9 months ago (2014-03-26 01:08:02 UTC) #2
Yuta Kitamura
https://codereview.chromium.org/210363006/diff/1/Source/core/editing/TextIterator.cpp File Source/core/editing/TextIterator.cpp (right): https://codereview.chromium.org/210363006/diff/1/Source/core/editing/TextIterator.cpp#newcode298 Source/core/editing/TextIterator.cpp:298: , m_entersAuthorShadowRoots(behavior & TextIteratorEntersAuthorShadowRoots) On 2014/03/26 01:08:02, Yoshi wrote: ...
6 years, 9 months ago (2014-03-26 01:58:58 UTC) #3
Yuta Kitamura
The CQ bit was checked by yutak@chromium.org
6 years, 9 months ago (2014-03-26 01:59:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yutak@chromium.org/210363006/1
6 years, 9 months ago (2014-03-26 01:59:07 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 02:07:58 UTC) #6
Message was sent while issue was closed.
Change committed as 170002

Powered by Google App Engine
This is Rietveld 408576698