Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 210363005: Fix issues when changing FLAG_concurrent_recompilation after init. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

Fix issues when changing FLAG_concurrent_recompilation after init. R=jarin@chromium.org BUG=356053 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=20228

Patch Set 1 #

Patch Set 2 : regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/heap.h View 2 chunks +3 lines, -7 lines 0 comments Download
M src/heap.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-356053.js View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
6 years, 9 months ago (2014-03-25 08:43:32 UTC) #1
Jarin
Could you add the regression test?
6 years, 9 months ago (2014-03-25 09:14:24 UTC) #2
Yang
On 2014/03/25 09:14:24, jarin wrote: > Could you add the regression test? done.
6 years, 9 months ago (2014-03-25 09:28:02 UTC) #3
Jarin
lgtm
6 years, 9 months ago (2014-03-25 09:32:23 UTC) #4
Yang
6 years, 9 months ago (2014-03-25 09:38:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20228 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698