Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2103613002: Subzero: Fix a potential null-pointer dereference. (Closed)

Created:
4 years, 5 months ago by Jim Stichnoth
Modified:
4 years, 5 months ago
Reviewers:
manasijm, Karl, John, Eric Holk
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/IceTargetLoweringX86BaseImpl.h View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jim Stichnoth
This was causing a crash translating an external pexe.
4 years, 5 months ago (2016-06-27 23:04:50 UTC) #3
John
lgtm
4 years, 5 months ago (2016-06-27 23:08:12 UTC) #4
manasijm
On 2016/06/27 23:04:50, stichnot wrote: > This was causing a crash translating an external pexe. ...
4 years, 5 months ago (2016-06-27 23:08:24 UTC) #5
Jim Stichnoth
4 years, 5 months ago (2016-06-27 23:11:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d615c8615ad5112f0e4359d08c51032cac7362b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698