Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: ash/system/tray/system_tray.h

Issue 2103603002: mash: Remove StatusAreaWidget references from system tray classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweak Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/tray/system_tray.h
diff --git a/ash/system/tray/system_tray.h b/ash/system/tray/system_tray.h
index 2b94af8fc5d9e4bbe6ddf794cb639b3613652a99..da55977ac77634800352db9ae171282d00476cc9 100644
--- a/ash/system/tray/system_tray.h
+++ b/ash/system/tray/system_tray.h
@@ -22,7 +22,6 @@ namespace ash {
enum class LoginStatus;
class ScreenTrayItem;
-class StatusAreaWidget;
class SystemBubbleWrapper;
class SystemTrayDelegate;
class SystemTrayItem;
@@ -30,6 +29,8 @@ class TrayAccessibility;
class TrayDate;
class TrayUpdate;
class TrayUser;
+class WebNotificationTray;
+class WmShelf;
// There are different methods for creating bubble views.
enum BubbleCreationType {
@@ -40,12 +41,16 @@ enum BubbleCreationType {
class ASH_EXPORT SystemTray : public TrayBackgroundView,
public views::TrayBubbleView::Delegate {
public:
- explicit SystemTray(StatusAreaWidget* status_area_widget);
+ explicit SystemTray(WmShelf* wm_shelf);
~SystemTray() override;
// Calls TrayBackgroundView::Initialize(), creates the tray items, and
// adds them to SystemTrayNotifier.
- void InitializeTrayItems(SystemTrayDelegate* delegate);
+ void InitializeTrayItems(SystemTrayDelegate* delegate,
+ WebNotificationTray* web_notification_tray);
+
+ // Resets internal pointers.
+ void Shutdown();
// Adds a new item in the tray.
void AddTrayItem(SystemTrayItem* item);
@@ -214,8 +219,8 @@ class ASH_EXPORT SystemTray : public TrayBackgroundView,
// Overridden from ActionableView.
bool PerformAction(const ui::Event& event) override;
- // The widget containing this view.
- StatusAreaWidget* status_area_widget_;
+ // The web notification tray for the display for this system tray.
msw 2016/06/27 23:57:36 Does a system tray potentially have multiple displ
James Cook 2016/06/28 00:47:26 Clarified that it's "the web notification tray vie
+ WebNotificationTray* web_notification_tray_;
// Owned items.
ScopedVector<SystemTrayItem> items_;

Powered by Google App Engine
This is Rietveld 408576698