Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2103603002: mash: Remove StatusAreaWidget references from system tray classes (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
Reviewers:
msw, stevenjb
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Remove StatusAreaWidget references from system tray classes Breaking this dependency will allow individual system tray pieces (e.g. the web notification tray) to be created without a StatusAreaWidget. This provides a path for ash/mus to instantiate its own status area widget and to add pieces one by one. Rename WebNotificationTray::SetSystemTrayHeight() to SetTrayBubbleHeight() so it is more clear what the SystemTray / WebNotificationTray dependency really is. Move //ash/system/web_notifications to //ash/common as this is its last non-common dependency. BUG=619636 TEST=ash_unittests TBR=stevenjb@chromium.org Committed: https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2 Cr-Commit-Position: refs/heads/master@{#402395}

Patch Set 1 #

Patch Set 2 : Move files #

Patch Set 3 : tweak #

Total comments: 6

Patch Set 4 : review comments, rename SetSystemTrayHeight to SetTrayBubbleHeight #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -1133 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/ash.gyp View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/system/web_notification/ash_popup_alignment_delegate.h View 1 2 3 3 chunks +9 lines, -9 lines 0 comments Download
A + ash/common/system/web_notification/ash_popup_alignment_delegate.cc View 1 2 3 4 chunks +11 lines, -11 lines 0 comments Download
A + ash/common/system/web_notification/web_notification_tray.h View 1 2 3 5 chunks +17 lines, -13 lines 0 comments Download
A + ash/common/system/web_notification/web_notification_tray.cc View 1 2 3 9 chunks +24 lines, -28 lines 0 comments Download
M ash/shell/window_type_launcher.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_button_tray.h View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M ash/system/chromeos/session/logout_button_tray.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/system/overview/overview_button_tray.h View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M ash/system/overview/overview_button_tray.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/system/status_area_widget.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/status_area_widget.cc View 1 5 chunks +12 lines, -13 lines 0 comments Download
M ash/system/tray/system_tray.h View 1 2 3 4 chunks +9 lines, -5 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 2 3 5 chunks +16 lines, -9 lines 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
D ash/system/web_notification/ash_popup_alignment_delegate.h View 1 1 chunk +0 lines, -98 lines 0 comments Download
D ash/system/web_notification/ash_popup_alignment_delegate.cc View 1 1 chunk +0 lines, -169 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 1 2 3 5 chunks +6 lines, -4 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 1 1 chunk +0 lines, -195 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 1 chunk +0 lines, -542 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 4 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
James Cook
msw, please take a look. StatusAreaWidget depends directly on several "tray" classes (overview button, logout ...
4 years, 5 months ago (2016-06-27 22:43:06 UTC) #2
msw
https://codereview.chromium.org/2103603002/diff/40001/ash/system/chromeos/session/logout_button_tray.h File ash/system/chromeos/session/logout_button_tray.h (right): https://codereview.chromium.org/2103603002/diff/40001/ash/system/chromeos/session/logout_button_tray.h#newcode22 ash/system/chromeos/session/logout_button_tray.h:22: class WmShelf; optional nit: rely on tray_background_view.h forward decl? ...
4 years, 5 months ago (2016-06-27 23:57:36 UTC) #3
James Cook
msw, please take another look. https://codereview.chromium.org/2103603002/diff/40001/ash/system/chromeos/session/logout_button_tray.h File ash/system/chromeos/session/logout_button_tray.h (right): https://codereview.chromium.org/2103603002/diff/40001/ash/system/chromeos/session/logout_button_tray.h#newcode22 ash/system/chromeos/session/logout_button_tray.h:22: class WmShelf; On 2016/06/27 ...
4 years, 5 months ago (2016-06-28 00:47:26 UTC) #5
msw
lgtm
4 years, 5 months ago (2016-06-28 01:03:08 UTC) #6
James Cook
TBR stevenjb for mechanical change to c/b/notifications
4 years, 5 months ago (2016-06-28 02:22:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103603002/60001
4 years, 5 months ago (2016-06-28 02:23:23 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-28 03:44:21 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 03:47:51 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2
Cr-Commit-Position: refs/heads/master@{#402395}

Powered by Google App Engine
This is Rietveld 408576698