third_party/WebKit/LayoutTests/fast/backgrounds/background-with-sub-pixel-offset-positioning.html - Issue 2103563002: Fix rounding of phase for background image

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/backgrounds/background-with-sub-pixel-offset-positioning.html

Issue 2103563002: Fix rounding of phase for background image (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Round the dest rect appropriately. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <style>	2 <style>

3 #float {	3 #float {

4 background: url('resources/bgimg1x50.png') 100% 0px no-repeat #FFF;	4 background: url('resources/bgimg1x50.png') 0% 0px no-repeat #FFF;
Stephen Chennney 2016/06/29 20:26:23 This test was wrong. With 100% position, the entir This test was wrong. With 100% position, the entire image should be outside the div and not visible. But previous rounding behavior magically made it work, I think by rounding down the dest rect and position so that something rendered inside the div.
5 height: 1px;	5 height: 1px;

6 width: 1.5px;	6 width: 1.5px;

7 position: relative;	7 position: relative;

8 left: 50px;	8 left: 50px;

9 transform: scale(50);	9 transform: scale(50);

10 }	10 }

11 #container {	11 #container {

12 margin-left: 1.5px;	12 margin-left: 1.5px;

13 overflow: hidden;	13 overflow: hidden;

14 width: 10px;	14 width: 10px;

15 height: 10px;	15 height: 10px;

16 }	16 }

17 </style>	17 </style>

18 <div id="container">	18 <div id="container">

19 <div id="float"></div>	19 <div id="float"></div>

20 </div>	20 </div>

OLD	NEW