scripts/slave/recipe_modules/chromium_android/example.py - Issue 2103553002: Check that device file exists first before reverting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_android/example.py

Issue 2103553002: Check that device file exists first before reverting. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: no expectations Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium_android/example.py

diff --git a/scripts/slave/recipe_modules/chromium_android/example.py b/scripts/slave/recipe_modules/chromium_android/example.py

index c49bae08d6c334cff7d03627b37deb900f6ed717..42185c6825a28dbf7b093a6912fbe32918b951c8 100644

--- a/scripts/slave/recipe_modules/chromium_android/example.py

+++ b/scripts/slave/recipe_modules/chromium_android/example.py

@@ -381,8 +381,15 @@ def GenTests(api):

'Invalid CTS output here...',

stream='stdout')))

+ yield (api.test('device_file_match') +

+ properties_for('tester') +

+ api.path.exists(

+ api.path['build'].join('site_config', '.known_devices')))

bpastene 2016/06/27 20:45:28 I have no idea how to get the actual path via api.

martiniss 2016/06/27 21:03:16 You can't call the real api in the test; you have

yield (api.test('device_file_format_mismatch') +

properties_for('tester') +

+ api.path.exists(

+ api.path['build'].join('site_config', '.known_devices')) +

api.override_step_data('fix_device_file_format.read_device_file',

api.raw_io.output('["device1", "device2"]')))

« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/api.py ('k') | no next file » | no next file with comments »