Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2103553002: Check that device file exists first before reverting. (Closed)

Created:
4 years, 5 months ago by bpastene
Modified:
4 years, 5 months ago
Reviewers:
jbudorick, martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Check that device file exists first before reverting. BUG=623655 Committed: https://chromium.googlesource.com/chromium/tools/build/+/2109cc6bcdca30f570e82fdbca959833b295efce

Patch Set 1 : no expectations #

Total comments: 2

Patch Set 2 : expectations #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5202 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +16 lines, -15 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.py View 1 chunk +7 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/coverage_builder_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
A + scripts/slave/recipe_modules/chromium_android/example.expected/device_file_match.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/device_flags_builder_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/downgrade_install_tester_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_refs.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_try_builder_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/java_method_count_builder_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/json_results_file_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/last_known_devices_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/no_cache_builder_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/no_strict_mode_tester_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_adb_vendor_keys_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_high_battery_temp_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_low_battery_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_disable_location_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_user_build_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_failure.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/resource_size_builder_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/restart_usb_builder_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/result_details_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/slow_tester_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/specific_install_tester_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_blacklisted_devices.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_no_devices.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_offline_devices.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_other_device_failure.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_with_step_warning.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tombstones_m53.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_expected_failure.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_output.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexecuted_tests.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexpected_class_failure.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexpected_method_failure.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_tester_basic.json View 1 2 chunks +0 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/cronet/example.expected/gn_test.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipe_modules/cronet/example.expected/local_test.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/missing_device.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/provision_devices.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/test_failure.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_fyi_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus6_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus7_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus9_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_one_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_cq.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_webview_arm64_aosp_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus9_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_cq.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_arm64_aosp_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus9_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_cq.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus9_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_cq.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_fyi_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5X_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus6_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus7_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus9_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_one_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_cq.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_arm64_aosp_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_fyi_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5X_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus6_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus7_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus9_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_one_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_cq.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_webview_arm64_aosp_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_fyi_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus5X_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus6_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus7_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus9_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_one_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_s5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_s5_perf_cq.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_webview_arm64_aosp_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_fyi_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5X_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus6_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus7_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus9_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_one_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_cq.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_webview_arm64_aosp_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_fyi_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5X_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus6_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus7_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus9_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_one_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_s5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_s5_perf_cq.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_webview_arm64_aosp_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json View 1 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/amp_split_recipe_collect_failure.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/amp_split_recipe_trigger_failure.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_with_timeout_scale.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_WebView_CTS_L_MR1__dbg_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_L__dbg_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_M__dbg_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Asan_Builder_Tests__dbg_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Coverage__dbg_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Remoting_Tests.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Tests__amp_split_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Tests__trial__dbg_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan_tester.json View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Android__Nexus4_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___K_Nexus5_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus5_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus6_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus7_2_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus9_.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_blink_rel.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_coverage.json View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_tester.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/cronet_try.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/local_test.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__dbg_.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__forced.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2_.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2__dbg_.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_tests__l_nexus9_.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__j_nexus4_.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__k_nexus5_.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__l_nexus6_.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_n6.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 1 2 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103553002/20001
4 years, 5 months ago (2016-06-27 20:34:13 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 20:40:05 UTC) #4
bpastene
https://codereview.chromium.org/2103553002/diff/1/scripts/slave/recipe_modules/chromium_android/example.py File scripts/slave/recipe_modules/chromium_android/example.py (right): https://codereview.chromium.org/2103553002/diff/1/scripts/slave/recipe_modules/chromium_android/example.py#newcode387 scripts/slave/recipe_modules/chromium_android/example.py:387: api.path['build'].join('site_config', '.known_devices'))) I have no idea how to get ...
4 years, 5 months ago (2016-06-27 20:45:29 UTC) #6
martiniss
lgtm from me, but probably get someone else to sign off https://codereview.chromium.org/2103553002/diff/1/scripts/slave/recipe_modules/chromium_android/example.py File scripts/slave/recipe_modules/chromium_android/example.py (right): ...
4 years, 5 months ago (2016-06-27 21:03:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103553002/20001
4 years, 5 months ago (2016-06-27 22:16:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/5773)
4 years, 5 months ago (2016-06-27 22:22:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103553002/40001
4 years, 5 months ago (2016-06-27 22:29:51 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/tools/build/+/2109cc6bcdca30f570e82fdbca959833b295efce
4 years, 5 months ago (2016-06-27 22:36:35 UTC) #16
jbudorick
4 years, 5 months ago (2016-06-28 07:34:45 UTC) #17
Message was sent while issue was closed. 
On 2016/06/27 21:03:17, martiniss wrote:
> lgtm from me, but probably get someone else to sign off

martiniss: why ^

> 
>
https://codereview.chromium.org/2103553002/diff/1/scripts/slave/recipe_module...
> File scripts/slave/recipe_modules/chromium_android/example.py (right):
> 
>
https://codereview.chromium.org/2103553002/diff/1/scripts/slave/recipe_module...
> scripts/slave/recipe_modules/chromium_android/example.py:387:
> api.path['build'].join('site_config', '.known_devices')))
> On 2016/06/27 at 20:45:28, bpastene wrote:
> > I have no idea how to get the actual path via
> api.chromium_android.known_devices_file, hence the hard coding right here.
> 
> You can't call the real api in the test; you have to hardcode it, which is
> generally ok in tests anyways.

Powered by Google App Engine
This is Rietveld 408576698