Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2103513002: fix fuzz bugs (Closed)

Created:
4 years, 5 months ago by caryclark
Modified:
4 years, 5 months ago
Reviewers:
Martin Barbella, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix fuzz bugs Detect more places where the pathops numerics cause numbers to become nearly identical and subsequently fail. These tests have extreme inputs and cannot succeed. Also remove the expectSuccess parameter from PathOpsDebug and check instead in the test framework. R=mbarbella@chromium.org TBR=reed@google.com BUG=623072, 623022 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103513002 Committed: https://skia.googlesource.com/skia/+/3f0753d3eccece8ac7f02f6af36d66a96c3dfb26

Patch Set 1 #

Patch Set 2 : fix spacing, add comment #

Patch Set 3 : disable test that fails to compute bounds on nexus 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/PathOpsOpTest.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103513002/20001
4 years, 5 months ago (2016-06-27 18:13:40 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 18:36:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103513002/20001
4 years, 5 months ago (2016-06-28 16:23:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/3f0753d3eccece8ac7f02f6af36d66a96c3dfb26
4 years, 5 months ago (2016-06-28 16:24:01 UTC) #9
Martin Barbella
4 years, 5 months ago (2016-06-28 17:41:37 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698