Fix chrome://offline-internal page.

Fix chrome://offline-internal page.

BUG=NONE
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ecee2797e46697f40d0cb20a1928dc7caf81e12c
Cr-Commit-Position: refs/heads/master@{#402692}

[Dmitry Titov, 2016-06-29 00:12:18]

Description was changed from

==========
Fix chrome://offline-internal page.

BUG=NONE
==========

to

==========
Fix chrome://offline-internal page.

BUG=NONE
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dmitry Titov, 2016-06-29 00:16:26]

dimich@chromium.org changed reviewers:
+ dpapad@chromium.org

[Dmitry Titov, 2016-06-29 00:16:26]

I think it was introduced by https://codereview.chromium.org/2089423002/, but
Cathy is OOO so I'd like to land this to unblock work...

Just an initialization order change.

[dpapad, 2016-06-29 00:22:18]

https://codereview.chromium.org/2103383003/diff/1/chrome/browser/resources/of...
File chrome/browser/resources/offline_pages/offline_internals.js (right):

https://codereview.chromium.org/2103383003/diff/1/chrome/browser/resources/of...
chrome/browser/resources/offline_pages/offline_internals.js:175: browserProxy_ =
Is there any good reason to not initialize this at line 15 along with the
declaration?

[Dmitry Titov, 2016-06-29 01:01:30]

https://codereview.chromium.org/2103383003/diff/1/chrome/browser/resources/of...
File chrome/browser/resources/offline_pages/offline_internals.js (right):

https://codereview.chromium.org/2103383003/diff/1/chrome/browser/resources/of...
chrome/browser/resources/offline_pages/offline_internals.js:175: browserProxy_ =
On 2016/06/29 00:22:18, dpapad wrote:
> Is there any good reason to not initialize this at line 15 along with the
> declaration?

Done.

[dpapad, 2016-06-29 01:03:14]

LGTM.

https://codereview.chromium.org/2103383003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/offline_pages/offline_internals.js (right):

https://codereview.chromium.org/2103383003/diff/20001/chrome/browser/resource...
chrome/browser/resources/offline_pages/offline_internals.js:14: /** @type
{offlineInternals.OfflineInternalsBrowserProxy} */
Nit: The type annotation can now be more accurate (to exclude null values), as
follows.

!offlineInternals.OfflineInternalsBrowserProxy

[Dmitry Titov, 2016-06-29 01:55:15]

> chrome/browser/resources/offline_pages/offline_internals.js:14: /** @type
> {offlineInternals.OfflineInternalsBrowserProxy} */
> Nit: The type annotation can now be more accurate (to exclude null values), as
> follows.
> 
> !offlineInternals.OfflineInternalsBrowserProxy

Updated. Thanks!

[Dmitry Titov, 2016-06-29 01:55:18]

The CQ bit was checked by dimich@chromium.org

[Dmitry Titov, 2016-06-29 01:55:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2103383003/#ps40001
(title: "updated type declaration")

[commit-bot: I haz the power, 2016-06-29 01:57:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 02:53:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-29 02:55:27]

Description was changed from

==========
Fix chrome://offline-internal page.

BUG=NONE
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix chrome://offline-internal page.

BUG=NONE
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ecee2797e46697f40d0cb20a1928dc7caf81e12c
Cr-Commit-Position: refs/heads/master@{#402692}
==========

[commit-bot: I haz the power, 2016-06-29 02:55:28]

Patchset 3 (id:??) landed as
https://crrev.com/ecee2797e46697f40d0cb20a1928dc7caf81e12c
Cr-Commit-Position: refs/heads/master@{#402692}