Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2103373002: Don't lazy allocate the AtomicStringTable. (Closed)

Created:
4 years, 5 months ago by esprehn
Modified:
4 years, 5 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't lazy allocate the AtomicStringTable. We can store the AtomicStringTable in a unique_ptr in the WTFThreadData directly and then use the constructor and destructor to handle adding and removing the strings. We can then return a reference too since all WTFThreadData instances have an AtomicStringTable. Future patches will move most of the AtomicString.cpp logic into the AtomicStringTable class making the code easier to understand. Committed: https://crrev.com/29b090287d0dc51ebe0a0ef38c4deda3531ee24e Cr-Commit-Position: refs/heads/master@{#402684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -87 lines) Patch
M third_party/WebKit/Source/wtf/WTFThreadData.h View 4 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/WTFThreadData.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicString.cpp View 2 chunks +3 lines, -73 lines 0 comments Download
A third_party/WebKit/Source/wtf/text/AtomicStringTable.h View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp View 1 chunk +39 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/wtf.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103373002/1
4 years, 5 months ago (2016-06-28 23:04:23 UTC) #2
esprehn
4 years, 5 months ago (2016-06-29 00:26:58 UTC) #4
haraken
LGTM
4 years, 5 months ago (2016-06-29 00:38:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103373002/1
4 years, 5 months ago (2016-06-29 00:55:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 02:38:20 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 02:40:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29b090287d0dc51ebe0a0ef38c4deda3531ee24e
Cr-Commit-Position: refs/heads/master@{#402684}

Powered by Google App Engine
This is Rietveld 408576698