Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 2103333006: Remove calls to deprecated MessageLoop methods in base. (Closed)

Created:
4 years, 5 months ago by fdoray
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, tracing+reviews_chromium.org, tfarina, chirantan+watch_chromium.org, sadrul, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in base. This CL makes the following replacements in base: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |x| isn't MessageLoopForUI::current() or MessageLoopForIO::current() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 Committed: https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3 Cr-Commit-Position: refs/heads/master@{#403224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -277 lines) Patch
M base/deferred_sequenced_task_runner_unittest.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M base/files/file_path_watcher_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/files/file_proxy_unittest.cc View 15 chunks +16 lines, -15 lines 0 comments Download
M base/files/file_util_proxy_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M base/files/important_file_writer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/mac/libdispatch_task_runner_unittest.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M base/message_loop/message_loop_task_runner_unittest.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M base/message_loop/message_loop_test.cc View 31 chunks +164 lines, -177 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 6 chunks +12 lines, -13 lines 0 comments Download
M base/message_loop/message_pump_libevent_unittest.cc View 5 chunks +15 lines, -10 lines 0 comments Download
M base/message_loop/message_pump_perftest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M base/observer_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sequence_checker_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M base/synchronization/waitable_event_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/launcher/test_launcher.cc View 2 chunks +2 lines, -1 line 0 comments Download
M base/test/power_monitor_test_base.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M base/test/sequenced_worker_pool_owner.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/test/test_message_loop.cc View 2 chunks +2 lines, -1 line 0 comments Download
M base/threading/thread.cc View 2 chunks +2 lines, -1 line 0 comments Download
M base/timer/timer_unittest.cc View 11 chunks +11 lines, -10 lines 0 comments Download
M base/trace_event/trace_event_system_stats_monitor_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
fdoray
Can you review this CL? Thanks.
4 years, 5 months ago (2016-06-30 13:41:28 UTC) #2
Lei Zhang
lgtm
4 years, 5 months ago (2016-06-30 16:52:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103333006/1
4 years, 5 months ago (2016-06-30 17:24:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 18:18:30 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 18:21:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1022458f506270ac5f1ac260916313847f7b54c3
Cr-Commit-Position: refs/heads/master@{#403224}

Powered by Google App Engine
This is Rietveld 408576698