Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: cc/surfaces/surface.h

Issue 2103333002: Revert of Make cc::CompositorFrames movable [Part 2 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/surfaces/display_unittest.cc ('k') | cc/surfaces/surface.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_SURFACES_SURFACE_H_ 5 #ifndef CC_SURFACES_SURFACE_H_
6 #define CC_SURFACES_SURFACE_H_ 6 #define CC_SURFACES_SURFACE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 SurfaceId previous_frame_surface_id() const { 47 SurfaceId previous_frame_surface_id() const {
48 return previous_frame_surface_id_; 48 return previous_frame_surface_id_;
49 } 49 }
50 50
51 void SetPreviousFrameSurface(Surface* surface); 51 void SetPreviousFrameSurface(Surface* surface);
52 void SetGpuMemoryBufferClientId(int gpu_memory_buffer_client_id); 52 void SetGpuMemoryBufferClientId(int gpu_memory_buffer_client_id);
53 int gpu_memory_buffer_client_id() const { 53 int gpu_memory_buffer_client_id() const {
54 return gpu_memory_buffer_client_id_; 54 return gpu_memory_buffer_client_id_;
55 } 55 }
56 56
57 void QueueFrame(CompositorFrame frame, const DrawCallback& draw_callback); 57 void QueueFrame(std::unique_ptr<CompositorFrame> frame,
58 const DrawCallback& draw_callback);
58 void RequestCopyOfOutput(std::unique_ptr<CopyOutputRequest> copy_request); 59 void RequestCopyOfOutput(std::unique_ptr<CopyOutputRequest> copy_request);
59 // Adds each CopyOutputRequest in the current frame to copy_requests. The 60 // Adds each CopyOutputRequest in the current frame to copy_requests. The
60 // caller takes ownership of them. 61 // caller takes ownership of them.
61 void TakeCopyOutputRequests( 62 void TakeCopyOutputRequests(
62 std::multimap<RenderPassId, std::unique_ptr<CopyOutputRequest>>* 63 std::multimap<RenderPassId, std::unique_ptr<CopyOutputRequest>>*
63 copy_requests); 64 copy_requests);
64
65 // Returns the most recent frame that is eligible to be rendered. 65 // Returns the most recent frame that is eligible to be rendered.
66 // If the CompositorFrame's DelegateFrameData is null then there is 66 const CompositorFrame* GetEligibleFrame();
67 // no eligible frame.
68 const CompositorFrame& GetEligibleFrame();
69 67
70 // Returns a number that increments by 1 every time a new frame is enqueued. 68 // Returns a number that increments by 1 every time a new frame is enqueued.
71 int frame_index() const { return frame_index_; } 69 int frame_index() const { return frame_index_; }
72 70
73 void TakeLatencyInfo(std::vector<ui::LatencyInfo>* latency_info); 71 void TakeLatencyInfo(std::vector<ui::LatencyInfo>* latency_info);
74 void RunDrawCallbacks(SurfaceDrawStatus drawn); 72 void RunDrawCallbacks(SurfaceDrawStatus drawn);
75 73
76 base::WeakPtr<SurfaceFactory> factory() { return factory_; } 74 base::WeakPtr<SurfaceFactory> factory() { return factory_; }
77 75
78 // Add a SurfaceSequence that must be satisfied before the Surface is 76 // Add a SurfaceSequence that must be satisfied before the Surface is
(...skipping 18 matching lines...) Expand all
97 95
98 private: 96 private:
99 void UnrefFrameResources(DelegatedFrameData* frame_data); 97 void UnrefFrameResources(DelegatedFrameData* frame_data);
100 void ClearCopyRequests(); 98 void ClearCopyRequests();
101 99
102 SurfaceId surface_id_; 100 SurfaceId surface_id_;
103 SurfaceId previous_frame_surface_id_; 101 SurfaceId previous_frame_surface_id_;
104 int gpu_memory_buffer_client_id_ = -1; 102 int gpu_memory_buffer_client_id_ = -1;
105 base::WeakPtr<SurfaceFactory> factory_; 103 base::WeakPtr<SurfaceFactory> factory_;
106 // TODO(jamesr): Support multiple frames in flight. 104 // TODO(jamesr): Support multiple frames in flight.
107 CompositorFrame current_frame_; 105 std::unique_ptr<CompositorFrame> current_frame_;
108 int frame_index_; 106 int frame_index_;
109 bool destroyed_; 107 bool destroyed_;
110 std::vector<SurfaceSequence> destruction_dependencies_; 108 std::vector<SurfaceSequence> destruction_dependencies_;
111 109
112 // This surface may have multiple BeginFrameSources if it is 110 // This surface may have multiple BeginFrameSources if it is
113 // on multiple Displays. 111 // on multiple Displays.
114 std::set<BeginFrameSource*> begin_frame_sources_; 112 std::set<BeginFrameSource*> begin_frame_sources_;
115 113
116 std::vector<SurfaceId> referenced_surfaces_; 114 std::vector<SurfaceId> referenced_surfaces_;
117 115
118 DrawCallback draw_callback_; 116 DrawCallback draw_callback_;
119 117
120 DISALLOW_COPY_AND_ASSIGN(Surface); 118 DISALLOW_COPY_AND_ASSIGN(Surface);
121 }; 119 };
122 120
123 } // namespace cc 121 } // namespace cc
124 122
125 #endif // CC_SURFACES_SURFACE_H_ 123 #endif // CC_SURFACES_SURFACE_H_
OLDNEW
« no previous file with comments | « cc/surfaces/display_unittest.cc ('k') | cc/surfaces/surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698