Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2103333002: Revert of Make cc::CompositorFrames movable [Part 2 of 2] (Closed)

Created:
4 years, 5 months ago by Pete Williamson
Modified:
4 years, 5 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, nasko+codewatch_chromium.org, piman+watch_chromium.org, rjkroege, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make cc::CompositorFrames movable [Part 2 of 2] (patchset #4 id:60001 of https://codereview.chromium.org/2098953003/ ) Reason for revert: It looks like this might have broken the tree compile: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/41520 Reverting as Sheriff Original issue's description: > Make cc::CompositorFrames movable [Part 2 of 2] > > This CL is part 2 of 2 for making cc::CompositorFrames > movable. This CL primarily tackles making cc::Surface > hold a cc::CompositorFrame by value. This impacts tons of > callsites which are updated in this patch. > > https://codereview.chromium.org/2096493002/ > > BUG=611802 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/2d9cc5abb4745280a002822a2380e925f835ef51 > Cr-Commit-Position: refs/heads/master@{#402545} TBR=reveman@chromium.org,boliu@chromium.org,danakj@chromium.org,piman@chromium.org,sky@chromium.org,fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=611802 Committed: https://crrev.com/03b9d1bd39dd290230d5b6a0860fa0ec4e0401bf Cr-Commit-Position: refs/heads/master@{#402561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+425 lines, -332 lines) Patch
M android_webview/browser/hardware_renderer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/display.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M cc/surfaces/display_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M cc/surfaces/surface.h View 2 chunks +4 lines, -6 lines 0 comments Download
M cc/surfaces/surface.cc View 7 chunks +37 lines, -35 lines 0 comments Download
M cc/surfaces/surface_aggregator.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_aggregator.cc View 9 chunks +29 lines, -22 lines 0 comments Download
M cc/surfaces/surface_aggregator_perftest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 43 chunks +203 lines, -158 lines 0 comments Download
M cc/surfaces/surface_display_output_surface.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/surfaces/surface_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_factory.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/surfaces/surface_factory_unittest.cc View 9 chunks +22 lines, -22 lines 0 comments Download
M cc/surfaces/surface_hittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/surfaces/surface_hittest_unittest.cc View 10 chunks +30 lines, -10 lines 0 comments Download
M cc/surfaces/surfaces_pixeltest.cc View 7 chunks +21 lines, -18 lines 0 comments Download
M cc/test/pixel_test_delegating_output_surface.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/exo/surface.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/mus/surfaces/display_compositor.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/surfaces/display_compositor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/ws/platform_display.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/platform_display.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M components/mus/ws/server_window_surface.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Pete Williamson
Created Revert of Make cc::CompositorFrames movable [Part 2 of 2]
4 years, 5 months ago (2016-06-28 21:59:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103333002/1
4 years, 5 months ago (2016-06-28 22:01:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 22:06:06 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 22:08:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03b9d1bd39dd290230d5b6a0860fa0ec4e0401bf
Cr-Commit-Position: refs/heads/master@{#402561}

Powered by Google App Engine
This is Rietveld 408576698