Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6766)

Unified Diff: chrome/browser/net/nqe/ui_network_quality_estimator_service_test_util.h

Issue 2103323007: Exposing NQE on the Browser UI thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/nqe/ui_network_quality_estimator_service_test_util.h
diff --git a/chrome/browser/net/nqe/ui_network_quality_estimator_service_test_util.h b/chrome/browser/net/nqe/ui_network_quality_estimator_service_test_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..ca845e91b3b07e96a48e5f88a19ae14683d5d9f9
--- /dev/null
+++ b/chrome/browser/net/nqe/ui_network_quality_estimator_service_test_util.h
@@ -0,0 +1,25 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NET_NQE_UI_NETWORK_QUALITY_ESTIMATOR_SERVICE_TEST_UTIL_H_
+#define CHROME_BROWSER_NET_NQE_UI_NETWORK_QUALITY_ESTIMATOR_SERVICE_TEST_UTIL_H_
+
+#include "net/nqe/network_quality_estimator.h"
+
+namespace chrome_browser_net {
+
+namespace test_util {
+
+// Prevents NQE from reporting EffectiveConnectionType to observers, and reports
tbansal1 2016/07/20 03:32:36 s/NQE/NetworkQualityEstimator/ s/and reports/and f
RyanSturm 2016/07/20 16:36:46 Done.
+// |type| to all EffectiveConnectionTypeObservers, including the
tbansal1 2016/07/20 03:32:35 s/all/all its/
RyanSturm 2016/07/20 16:36:46 Done.
+// UINetworkQualityEstimatorService.
tbansal1 2016/07/20 03:32:36 I do not think you should say anything about UINet
RyanSturm 2016/07/20 16:36:46 Done.
+// This blocks the UI thread until the IO task runs and replies.
tbansal1 2016/07/20 03:32:36 s/UI thread/calling thread/
RyanSturm 2016/07/20 16:36:46 Done.
+void OverrideEffectiveConnectionTypeAndWait(
+ net::NetworkQualityEstimator::EffectiveConnectionType type);
+
+} // namespace test_util
+
+} // namespace chrome_browser_net
+
+#endif // CHROME_BROWSER_NET_NQE_UI_NETWORK_QUALITY_ESTIMATOR_SERVICE_TEST_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698