Exposing NQE on the Browser UI thread

chrome/browser/net/nqe/ui_network_quality_estimator_service.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NET_NQE_UI_NETWORK_QUALITY_ESTIMATOR_SERVICE_H_
+#define CHROME_BROWSER_NET_NQE_UI_NETWORK_QUALITY_ESTIMATOR_SERVICE_H_
+
+#include <memory>
+
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "base/single_thread_task_runner.h"
+#include "components/keyed_service/core/keyed_service.h"
+#include "net/nqe/network_quality_estimator.h"
+
+class Profile;
+
+namespace chrome_browser_net {
+
+class UINetworkQualityEstimatorService : public KeyedService {
+ public:
+  explicit UINetworkQualityEstimatorService(Profile* profile);
+  ~UINetworkQualityEstimatorService() override;
+
+  void EffectiveConnectionTypeChanged(
+      net::NetworkQualityEstimator::EffectiveConnectionType type_);
+
+  void Initialize(scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,

[tbansal1, 2016/07/13 00:07:28]

pass as const ref?

[RyanSturm, 2016/07/13 17:28:15]

Done.

+                  scoped_refptr<base::SingleThreadTaskRunner> io_task_runner);
+
+  void Shutdown() override;
+
+  net::NetworkQualityEstimator::EffectiveConnectionType type() { return type_; }

[tbansal1, 2016/07/13 00:07:28]

const function
Also, I think you should move the body to .cc, and add thread checker.

[RyanSturm, 2016/07/13 17:28:14]

Done.

+
+ private:
+  net::NetworkQualityEstimator::EffectiveConnectionType type_;
+  scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;

[tbansal1, 2016/07/13 00:07:28]

include: base/memory/ref_counted.h

[RyanSturm, 2016/07/13 17:28:14]

Done.

+  class IONetworkQualityObserver;

[tbansal1, 2016/07/13 00:07:28]

This should be the first line in the private.

[RyanSturm, 2016/07/13 17:28:14]

Done.

+  IONetworkQualityObserver* io_observer_;
+  base::ThreadChecker thread_checker_;
+
+  base::WeakPtrFactory<UINetworkQualityEstimatorService> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(UINetworkQualityEstimatorService);
+};
+
+}  // namespace chrome_browser_net
+
+#endif  // CHROME_BROWSER_NET_NQE_UI_NETWORK_QUALITY_ESTIMATOR_SERVICE_H_