Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2103323006: DevTools: fix javascript pretty-printing of semicolon in some cases (Closed)

Created:
4 years, 5 months ago by lushnikov
Modified:
4 years, 5 months ago
Reviewers:
paulirish, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix javascript pretty-printing of semicolon in some cases BUG=618235 R=dgozman Committed: https://crrev.com/8cb8ae83c17c3d841794df0e9a23a996066c2106 Cr-Commit-Position: refs/heads/master@{#403813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-7.html View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-7-expected.txt View 1 chunk +46 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptFormatter.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
lushnikov
please, take a look
4 years, 5 months ago (2016-07-01 19:05:38 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103323006/1
4 years, 5 months ago (2016-07-01 19:06:50 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 20:30:31 UTC) #5
lushnikov
Paul, could you please take a look?
4 years, 5 months ago (2016-07-01 22:10:27 UTC) #7
dgozman
lgtm
4 years, 5 months ago (2016-07-05 17:39:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103323006/1
4 years, 5 months ago (2016-07-05 17:39:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 18:54:22 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 18:54:24 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 18:57:09 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8cb8ae83c17c3d841794df0e9a23a996066c2106
Cr-Commit-Position: refs/heads/master@{#403813}

Powered by Google App Engine
This is Rietveld 408576698