Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2103323004: Update weak_ptr_unittest.nc expectation (Closed)

Created:
4 years, 5 months ago by tzik
Modified:
4 years, 5 months ago
Reviewers:
dcheng
CC:
chromium-reviews, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update weak_ptr_unittest.nc expectation Clang starts refusing the pointer conversion to an ambiguous ancestor. That causes another compile error in a nocompile test. https://llvm.org/bugs/show_bug.cgi?id=28195 Committed: https://crrev.com/4d306c66208433e1510db90d6f561d088011b3a2 Cr-Commit-Position: refs/heads/master@{#403104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/memory/weak_ptr_unittest.nc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
tzik
PTAL
4 years, 5 months ago (2016-06-30 05:45:03 UTC) #3
dcheng
lgtm
4 years, 5 months ago (2016-06-30 05:55:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103323004/1
4 years, 5 months ago (2016-06-30 06:04:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 06:53:06 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 06:53:13 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 06:55:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d306c66208433e1510db90d6f561d088011b3a2
Cr-Commit-Position: refs/heads/master@{#403104}

Powered by Google App Engine
This is Rietveld 408576698