Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2103293004: Add font failure telemetry (Closed)

Created:
4 years, 5 months ago by Ilya Kulshin
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add font failure telemetry Adds some telemetry which might help us diagnose the cause of issue 561873. BUG=561873 Committed: https://crrev.com/9dde4efb888159a44ba56cdea254c15a984f69e3 Cr-Commit-Position: refs/heads/master@{#404064}

Patch Set 1 #

Patch Set 2 : More telemetry #

Total comments: 4

Patch Set 3 : Change units in histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -5 lines) Patch
M content/browser/renderer_host/dwrite_font_proxy_message_filter_win.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc View 1 2 8 chunks +72 lines, -3 lines 0 comments Download
M content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc View 8 chunks +34 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 chunks +56 lines, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
Ilya Kulshin
ptal
4 years, 5 months ago (2016-06-30 18:22:04 UTC) #3
Ilya Kulshin
+asvitkine,rkaplow - could you review histograms.xml?
4 years, 5 months ago (2016-06-30 19:46:04 UTC) #5
ananta
lgtm
4 years, 5 months ago (2016-06-30 20:01:57 UTC) #6
rkaplow
lgtm https://codereview.chromium.org/2103293004/diff/20001/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc File content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc (right): https://codereview.chromium.org/2103293004/diff/20001/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc#newcode18 content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc:18: #include "base/macros.h" should be adding histogram_macros.h https://codereview.chromium.org/2103293004/diff/20001/tools/metrics/histograms/histograms.xml File ...
4 years, 5 months ago (2016-07-04 14:45:02 UTC) #7
Ilya Kulshin
https://codereview.chromium.org/2103293004/diff/20001/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc File content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc (right): https://codereview.chromium.org/2103293004/diff/20001/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc#newcode18 content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc:18: #include "base/macros.h" On 2016/07/04 14:45:01, rkaplow wrote: > should ...
4 years, 5 months ago (2016-07-06 17:56:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103293004/40001
4 years, 5 months ago (2016-07-06 17:56:52 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99209)
4 years, 5 months ago (2016-07-06 20:18:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103293004/40001
4 years, 5 months ago (2016-07-07 02:57:20 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-07 03:38:25 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 03:39:55 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9dde4efb888159a44ba56cdea254c15a984f69e3
Cr-Commit-Position: refs/heads/master@{#404064}

Powered by Google App Engine
This is Rietveld 408576698