🎐 Default chromium_code = false for Android targets within third_party

build/config/android/internal_rules.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 
 assert(is_android)
 
 # Write the target's .build_config file. This is a json file that contains a
@@ skipping 1967 matching lines @@
 
     if (defined(invoker.run_findbugs_override)) {
       _run_findbugs = invoker.run_findbugs_override
     } else {
       _run_findbugs = run_findbugs  # Default to build arg if not overridden.
     }
     assert(_run_findbugs || true)  # Mark as used.
 
     # Don't enable coverage, lint, findbugs unless the target has some
     # non-generated files.
-    _chromium_code = defined(invoker.java_files) && invoker.java_files != []
     if (defined(invoker.chromium_code)) {
       _chromium_code = invoker.chromium_code
+    } else {
+      _chromium_code = defined(invoker.java_files) && invoker.java_files != []
+      if (_chromium_code) {
+        # Make chromium_code = false be the default for targets within
+        # third_party which contain no chromium-namespaced java files.
+        set_sources_assignment_filter([ "*\bthird_party\b*" ])
+        sources = [

[Yaron, 2016/06/29 15:29:20]

Is this a local variable? Prefix with "_" or are you intentionally overriding
this value?

[agrieve, 2016/06/29 17:47:42]

This is currently the only way to do filtering in GN.
set_sources_assignment_filter applies only to the variables named "sources" :P

[Yaron, 2016/06/29 18:16:22]

So there's no need to cache and restore it after?
Sorry for the naive questions but my familiarity with this is pretty low

[agrieve, 2016/06/29 18:46:40]

It's restored (back to []) on line 2004. GN also resets it on each scope enter /
exit.

[Yaron, 2016/06/29 18:48:49]

Ya, I getcha. I was wondering if sources could be non-empty before this 

+          get_label_info(":$target_name", "dir"),
+        ]
+        if (sources == []) {
+          set_sources_assignment_filter([ "*\bchromium\b*" ])
+          sources = invoker.java_files
+          _chromium_code = invoker.java_files != sources
+        }
+        set_sources_assignment_filter([])
+        sources = []
+      }
     }
 
     _emma_never_instrument = !_chromium_code
     if (defined(invoker.emma_never_instrument)) {
       _emma_never_instrument = invoker.emma_never_instrument
     }
     assert(_emma_never_instrument || true)  # Mark as used
     _emma_instrument = emma_coverage && !_emma_never_instrument
 
     if (_supports_android) {
@@ skipping 394 matching lines @@
       outputs = [
         depfile,
         invoker.out_manifest,
       ]
       inputs = [
         invoker.main_manifest,
       ]
     }
   }
 }