Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java

Issue 2103243002: Factor out ContentViewAndroidDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java
diff --git a/ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java b/ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java
index 6d3694cc9bfe1304dd81fce41b8c3691be883f0a..5b5c88c630c6de5c584be58ea09755021a43b750 100644
--- a/ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java
+++ b/ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java
@@ -12,19 +12,16 @@ import android.view.View;
public interface ViewAndroidDelegate {
/**
- * @return An anchor view that can be used to anchor decoration views like Autofill popup.
- */
- View acquireAnchorView();
-
- /**
- * Set the anchor view to specified position and width (all units in dp).
- * @param view The anchor view that needs to be positioned.
+ * Add a view used to anchor decoration views like Autofill popup, and
+ * set the anchor view to specified position and width (all units in dp).
+ * @param anchorView The anchor view that needs to be positioned.
* @param x X coordinate of the top left corner of the anchor view.
* @param y Y coordinate of the top left corner of the anchor view.
* @param width The width of the anchor view.
* @param height The height of the anchor view.
+ * @return A newly added view
*/
- void setAnchorViewPosition(View view, float x, float y, float width, float height);
+ void addView(View anchorView, float x, float y, float width, float height);
/**
* Release given anchor view.

Powered by Google App Engine
This is Rietveld 408576698