chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java - Issue 2103243002: Factor out ContentViewAndroidDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java

Issue 2103243002: Factor out ContentViewAndroidDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/autofill/autofill_popup_view_android.cc ('K') | « chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc ('k') | content/browser/android/content_view_core_impl.h » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentViewAndroidDelegate.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java

diff --git a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java

index c1c3952f939f6e54e51d686670d80654908b5517..ae04edad4cc4a979407a4d19b1a0306bfc4d746e 100644

--- a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java

+++ b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java

@@ -18,6 +18,7 @@ import android.widget.LinearLayout;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.JNINamespace;

import org.chromium.content.browser.ContentView;

+import org.chromium.content.browser.ContentViewAndroidDelegate;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.ContentViewRenderView;

import org.chromium.content_public.browser.LoadUrlParams;

@@ -128,7 +129,9 @@ public class CastWindowAndroid extends LinearLayout {

Context context = getContext();

mContentViewCore = new ContentViewCore(context);

ContentView view = ContentView.createContentView(context, mContentViewCore);

- mContentViewCore.initialize(view, view, webContents, mWindow);

+ ContentViewAndroidDelegate delegate = new ContentViewAndroidDelegate(view,

+ mContentViewCore.getRenderCoordinates());

+ mContentViewCore.initialize(view, delegate, view, webContents, mWindow);

mWebContents = mContentViewCore.getWebContents();

mNavigationController = mWebContents.getNavigationController();

mRenderProcessId = renderProcessId;