chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java - Issue 2103243002: Factor out ContentViewAndroidDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

Issue 2103243002: Factor out ContentViewAndroidDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java ('k') | chrome/browser/ui/android/autofill/autofill_popup_view_android.cc » ('j') | chrome/browser/ui/android/autofill/autofill_popup_view_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

index 747477f897862d3e5f981c010c4148137066eb43..208693429b42649608a28df5929b7c4a30304311 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

@@ -13,6 +13,7 @@ import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.WebContentsFactory;

import org.chromium.chrome.test.ChromeActivityTestCaseBase;

import org.chromium.content.browser.ContentView;

+import org.chromium.content.browser.ContentViewAndroidDelegate;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

@@ -87,7 +88,9 @@ public class SelectPopupOtherContentViewTest extends ChromeActivityTestCaseBase<

ContentViewCore contentViewCore = new ContentViewCore(getActivity());

ContentView cv = ContentView.createContentView(getActivity(), contentViewCore);

- contentViewCore.initialize(cv, cv, webContents, windowAndroid);

+ ContentViewAndroidDelegate viewDelegate = new ContentViewAndroidDelegate(

+ cv, contentViewCore.getRenderCoordinates());

+ contentViewCore.initialize(cv, viewDelegate, cv, webContents, windowAndroid);

contentViewCore.destroy();

}

});