android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java - Issue 2103243002: Factor out ContentViewAndroidDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java

Issue 2103243002: Factor out ContentViewAndroidDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | chrome/browser/ui/android/autofill/autofill_popup_view_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java b/android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java

index 172c2b384f03a6bb2115075cda180d040e5b34fb..3deb8524925ba7b298ce41bbfa48275637f5d270 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java

@@ -49,6 +49,8 @@ public class AwAutofillClient {

if (mAutofillPopup == null) {

mAutofillPopup = new AutofillPopup(

mContentViewCore.getContext(),

+ mContentViewCore.acquireAnchorView(x, y, width, height),

+ width,

mContentViewCore.getViewAndroidDelegate(),

new AutofillDelegate() {

@Override

@@ -61,7 +63,6 @@ public class AwAutofillClient {

public void deleteSuggestion(int listIndex) { }

});

}

- mAutofillPopup.setAnchorRect(x, y, width, height);

mAutofillPopup.filterAndShow(suggestions, isRtl);

}