Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java

Issue 2103243002: Factor out ContentViewAndroidDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java
index d135710bd364345bb77d603a8b8ad46f84d33597..b9437f0956fb78b70bd2e51ac8de8effe1943407 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java
@@ -5,13 +5,11 @@
package org.chromium.content.browser.input;
import android.content.Context;
-import android.graphics.Rect;
import android.view.View;
import android.widget.AdapterView;
import android.widget.PopupWindow;
import org.chromium.content.browser.ContentViewCore;
-import org.chromium.content.browser.RenderCoordinates;
import org.chromium.ui.DropdownAdapter;
import org.chromium.ui.DropdownPopupWindow;
@@ -28,12 +26,11 @@ public class SelectPopupDropdown implements SelectPopup {
private boolean mSelectionNotified;
- public SelectPopupDropdown(ContentViewCore contentViewCore, List<SelectPopupItem> items,
- Rect bounds, int[] selected, boolean rightAligned) {
+ public SelectPopupDropdown(ContentViewCore contentViewCore, View anchorView,
+ List<SelectPopupItem> items, int[] selected, boolean rightAligned) {
mContentViewCore = contentViewCore;
mContext = mContentViewCore.getContext();
- mDropdownPopupWindow = new DropdownPopupWindow(mContext,
- mContentViewCore.getViewAndroidDelegate());
+ mDropdownPopupWindow = new DropdownPopupWindow(mContext, anchorView);
mDropdownPopupWindow.setOnItemClickListener(new AdapterView.OnItemClickListener() {
@Override
public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
@@ -49,16 +46,6 @@ public class SelectPopupDropdown implements SelectPopup {
mDropdownPopupWindow.setInitialSelection(initialSelection);
mDropdownPopupWindow.setAdapter(new DropdownAdapter(mContext, items, null));
mDropdownPopupWindow.setRtl(rightAligned);
- RenderCoordinates renderCoordinates = mContentViewCore.getRenderCoordinates();
- float anchorX = renderCoordinates.fromPixToDip(
- renderCoordinates.fromLocalCssToPix(bounds.left));
- float anchorY = renderCoordinates.fromPixToDip(
- renderCoordinates.fromLocalCssToPix(bounds.top));
- float anchorWidth = renderCoordinates.fromPixToDip(
- renderCoordinates.fromLocalCssToPix(bounds.right)) - anchorX;
- float anchorHeight = renderCoordinates.fromPixToDip(
- renderCoordinates.fromLocalCssToPix(bounds.bottom)) - anchorY;
- mDropdownPopupWindow.setAnchorRect(anchorX, anchorY, anchorWidth, anchorHeight);
mDropdownPopupWindow.setOnDismissListener(
new PopupWindow.OnDismissListener() {
@Override

Powered by Google App Engine
This is Rietveld 408576698