Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2103243002: Factor out ContentViewAndroidDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 71313304b525e0377897de69f8c8604e1775f89e..7b182a1b9264cf3a21f1deebea00abcb8c472be9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -114,6 +114,7 @@ import org.chromium.ui.WindowOpenDisposition;
import org.chromium.ui.base.DeviceFormFactor;
import org.chromium.ui.base.LocalizationUtils;
import org.chromium.ui.base.PageTransition;
+import org.chromium.ui.base.ViewAndroidDelegate;
import org.chromium.ui.base.WindowAndroid;
import java.lang.ref.WeakReference;
@@ -1799,7 +1800,8 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
ContentView cv = ContentView.createContentView(mThemedApplicationContext, cvc);
cv.setContentDescription(mThemedApplicationContext.getResources().getString(
R.string.accessibility_content_view));
- cvc.initialize(cv, cv, webContents, getWindowAndroid());
+ cvc.initialize(ViewAndroidDelegate.createBasicDelegate(cv), cv, webContents,
+ getWindowAndroid());
setContentViewCore(cvc);
if (getTabModelSelector() instanceof SingleTabModelSelector) {
getContentViewCore().setFullscreenRequiredForOrientationLock(false);
@@ -2481,7 +2483,8 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
ContentView cv = ContentView.createContentView(mThemedApplicationContext, cvc);
cv.setContentDescription(mThemedApplicationContext.getResources().getString(
R.string.accessibility_content_view));
- cvc.initialize(cv, cv, webContents, getWindowAndroid());
+ cvc.initialize(ViewAndroidDelegate.createBasicDelegate(cv), cv, webContents,
+ getWindowAndroid());
swapContentViewCore(cvc, false, didStartLoad, didFinishLoad);
}

Powered by Google App Engine
This is Rietveld 408576698