Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 2103243002: Factor out ContentViewAndroidDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments chrome/webview Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc ('K') | « chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java ('k') | content/browser/android/content_view_core_impl.cc » ('j') | content/browser/android/content_view_core_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index df0276b8d4ecdc7b0c6f7deb023d748e14db056a..4ff1d1b116670ce121dced2d70d4f7c3eb95e6d1 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -61,8 +61,6 @@ class ContentViewCoreImpl : public ContentViewCore,
base::android::ScopedJavaLocalRef<jobject> GetJavaObject() override;
WebContents* GetWebContents() const override;
ui::WindowAndroid* GetWindowAndroid() const override;
- const base::android::JavaRef<jobject>& GetViewAndroidDelegate()
- const override;
cc::Layer* GetLayer() const override;
bool ShowPastePopup(int x, int y) override;
void PauseOrResumeGeolocation(bool should_pause) override;
@@ -449,6 +447,9 @@ class ContentViewCoreImpl : public ContentViewCore,
// A weak reference to the Java ContentViewCore object.
JavaObjectWeakGlobalRef java_ref_;
+ // Select popup view
+ ui::ViewAndroid::ScopedAnchorView select_popup_;
+
ui::ViewAndroid view_;
// Reference to the current WebContents used to determine how and what to
« chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc ('K') | « chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java ('k') | content/browser/android/content_view_core_impl.cc » ('j') | content/browser/android/content_view_core_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698