Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

Issue 2103243002: Factor out ContentViewAndroidDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java
index 747477f897862d3e5f981c010c4148137066eb43..9fa94711d4325ff23fb09e8a272cc0c74d9977e6 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java
@@ -5,6 +5,7 @@
package org.chromium.chrome.browser.input;
import android.test.suitebuilder.annotation.LargeTest;
+import android.view.ViewGroup;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Feature;
@@ -19,6 +20,7 @@ import org.chromium.content.browser.test.util.CriteriaHelper;
import org.chromium.content.browser.test.util.DOMUtils;
import org.chromium.content_public.browser.WebContents;
import org.chromium.ui.base.ActivityWindowAndroid;
+import org.chromium.ui.base.ViewAndroidDelegate;
import org.chromium.ui.base.WindowAndroid;
/**
@@ -87,7 +89,20 @@ public class SelectPopupOtherContentViewTest extends ChromeActivityTestCaseBase<
ContentViewCore contentViewCore = new ContentViewCore(getActivity());
ContentView cv = ContentView.createContentView(getActivity(), contentViewCore);
- contentViewCore.initialize(cv, cv, webContents, windowAndroid);
+ contentViewCore.initialize(cv,
+ new ViewAndroidDelegate() {
+ private ViewGroup mContainerView;
+
+ private ViewAndroidDelegate init(ViewGroup containerView) {
+ mContainerView = containerView;
+ return this;
+ }
+
+ @Override
+ public ViewGroup getContainerView() {
+ return mContainerView;
+ }
+ }.init(cv), cv, webContents, windowAndroid);
contentViewCore.destroy();
}
});

Powered by Google App Engine
This is Rietveld 408576698