Factor out ContentViewAndroidDelegate

chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java

Index: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java
index f0a2a30af8241df653bae91915bf558195c6f0be..68b1b49dbd8d883c70cad6246f8e2ae278986af1 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java
@@ -5,6 +5,7 @@
 package org.chromium.chrome.browser.autofill;
 
 import android.test.suitebuilder.annotation.SmallTest;
+import android.view.View;
 
 import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout;
 
@@ -54,14 +55,16 @@ public class AutofillTest extends ChromeActivityTestCaseBase<ChromeActivity> {
         mMockAutofillCallback = new MockAutofillCallback();
         final ViewAndroidDelegate viewDelegate =
                 activity.getCurrentContentViewCore().getViewAndroidDelegate();

[no sievers, 2016/07/18 22:14:16]

This is a weird test. It's really a unit test for AutofillPopup, since it
doesn't use any of the actual implementation's logic (doesn't even use
AutofillClient).

It spins up a whole browser to then extract the delegate from the container view
and then unit test the feature.

I think it should either be a proper integration test based on some html that we
load and then somehow tests if we can properly populate the form.

Or it can stay as is and then doesn't need to spin up a whole browser but just
instantiate an AutofillPopup (and giving it a dummy anchor view).

We can do this separately, but maybe CVC.getViewAndroidDelegate() can then
become @VisibleForTesting with a TODO to remove it.

[Jinsuk Kim, 2016/07/19 07:08:39]

Marked the method with @VisibleForTesting and left a TODO.

-
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
+                View anchorView = viewDelegate.acquireView();
+                viewDelegate.setViewPosition(anchorView, 50f, 500f, 500f, 500f, 1f, 10, 10);
+
                 mWindowAndroid = new ActivityWindowAndroid(activity);
-                mAutofillPopup = new AutofillPopup(activity, viewDelegate, mMockAutofillCallback);
+                mAutofillPopup = new AutofillPopup(activity, anchorView, 500f,
+                        mMockAutofillCallback);
                 mAutofillPopup.filterAndShow(new AutofillSuggestion[0], false);
-                mAutofillPopup.setAnchorRect(50, 500, 500, 50);
             }
         });
     }